Skip to content

Krige: Adapting to PyKrige#160

Merged
MuellerSeb merged 4 commits intodevelopfrom
pykrige_compat
Apr 13, 2021
Merged

Krige: Adapting to PyKrige#160
MuellerSeb merged 4 commits intodevelopfrom
pykrige_compat

Conversation

@MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Apr 11, 2021

This PR updates the PyKrige interface example and replaces the pseudo_inv_type options (1, 2, 3) in all Kriging routines with more descriptive ones to be in line with the settings in PyKrige:

pseudo_inv_type : :class:`str` or :any:`callable`, optional
    Here you can select the algorithm to compute the pseudo-inverse matrix:

        * `"pinv"`: use `pinv` from `scipy` which uses `lstsq`
        * `"pinv2"`: use `pinv2` from `scipy` which uses `SVD`
        * `"pinvh"`: use `pinvh` from `scipy` which uses eigen-values

    If you want to use another routine to invert the kriging matrix,
    you can pass a callable which takes a matrix and returns the inverse.
    Default: `"pinv"`

See:

@MuellerSeb MuellerSeb added the Refactoring Code-Refactoring needed here label Apr 11, 2021
@MuellerSeb MuellerSeb added this to the 1.3 milestone Apr 11, 2021
@MuellerSeb MuellerSeb requested a review from LSchueler April 11, 2021 19:42
@MuellerSeb MuellerSeb self-assigned this Apr 11, 2021
@MuellerSeb MuellerSeb changed the title Krige: use same pseudo_inv_type options as PyKrige Krige: Adapting to PyKrige Apr 11, 2021
@MuellerSeb
Copy link
Member Author

@LSchueler this is ready for review.

Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from being consistent with PyKrige, this is much nicer than before! I even have the feeling, that we already discussed this once. 👍

@MuellerSeb MuellerSeb merged commit 773c538 into develop Apr 13, 2021
@MuellerSeb MuellerSeb deleted the pykrige_compat branch April 13, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactoring Code-Refactoring needed here

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants