Merged
Conversation
…and 'vario_estimate'
Member
Author
|
@LSchueler this is ready for review. |
LSchueler
approved these changes
Apr 13, 2021
Member
LSchueler
left a comment
LSchueler
left a comment
There was a problem hiding this comment.
This is a nice little addition towards better practicability of the variogram estimation, thanks!
I'm wondering if things are getting so complex with all the different return branches, that this should somehow be covered by the unit tests or if this is still manageable in the good old fassioned way, by simply leaning back and taking a sharp look at it... ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds optional return of
normalizerinvario_estimatewhenfit_normalizer=True.Closes: #161