Conversation
Member
Author
|
This commit is a first step towards arbitrary dimensions. |
MuellerSeb
requested changes
Aug 18, 2020
Member
MuellerSeb
left a comment
MuellerSeb
left a comment
There was a problem hiding this comment.
I'd say: LGTM. It looks much cleaner.
Comment on lines
+120
to
+126
| # quick and dirty assembly of pos | ||
| if dim == 1: | ||
| pos = np.atleast_2d(x) | ||
| elif dim == 2: | ||
| pos = np.array((x, y)) | ||
| else: | ||
| pos = np.array((x, y, z)) |
Member
There was a problem hiding this comment.
Why not use the xyz2pos routine here?
Member
|
I implemented this with 73f1b68 There, parallelism is working. Closing this one in favor of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue #77 and in the PyKrige issue we want to support arbitrary field dimensions.