fix: Add config showHeader to Post list config for simple theme#2497
Open
willismonroe wants to merge 2 commits intoGetPublii:masterfrom
Open
fix: Add config showHeader to Post list config for simple theme#2497willismonroe wants to merge 2 commits intoGetPublii:masterfrom
willismonroe wants to merge 2 commits intoGetPublii:masterfrom
Conversation
Add new config value of showHeader to Post list group
Add conditional viewing of header based on value of showHeader config in Post list group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the same issue as the poster here: #1961
I made a small change to the simple theme config that allows you to show or hide the header text. It would be nice to make the text itself configurable down the road, but I figured showing and hiding the text was at least desirable.