Open
Conversation
there seems to be some confusion in the previous comment.
Collaborator
mjwilson-google
left a comment
mjwilson-google
left a comment
There was a problem hiding this comment.
Thank you for your contribution! I think you're right, and this is much more clear.
I have a couple of nits/questions; please let me know what you think.
Comment on lines
+83
to
+84
| startByteOffset >> 2, | ||
| endByteOffset >> 2); |
Collaborator
There was a problem hiding this comment.
For even more clarity, what do you think about either of these options?
- Make the
2a named constant likeFLOAT32_INDEX_SHIFT
or
- Use division by
BYTES_PER_SAMPLEalong withMath.floor()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there seems to be some confusion in the previous comment.