Skip to content

Add terraform support for Named API#16564

Merged
ScottSuarez merged 8 commits intoGoogleCloudPlatform:mainfrom
akshat-jindal-nit:name-set
Mar 4, 2026
Merged

Add terraform support for Named API#16564
ScottSuarez merged 8 commits intoGoogleCloudPlatform:mainfrom
akshat-jindal-nit:name-set

Conversation

@akshat-jindal-nit
Copy link
Contributor

@akshat-jindal-nit akshat-jindal-nit commented Feb 27, 2026

API to create a NamedSet: b/422038058

A Named Set is a collection of IP addresses or ranges (for PREFIX type) or
BGP communities (for COMMUNITY type) that can be used in route policies.

`google_compute_router_named_set` (beta)

@github-actions github-actions bot requested a review from ScottSuarez February 27, 2026 07:34
@github-actions
Copy link

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 292 insertions(+))
google-beta provider: Diff ( 5 files changed, 1312 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 223 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_router_named_set (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_named_set" "primary" {
  elements {
    location = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_router_named_set

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 292 insertions(+))
google-beta provider: Diff ( 5 files changed, 1312 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 223 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_router_named_set (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_named_set" "primary" {
  elements {
    location = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_router_named_set

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1370
Passed tests: 1277
Skipped tests: 90
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterNamedSet_routerNamedSetCommunityExample
  • TestAccComputeRouterNamedSet_routerNamedSetPrefixExample
  • TestAccComputeRouterNamedSet_routerNamedSetRoutePolicyExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterNamedSet_routerNamedSetCommunityExample [Debug log]
TestAccComputeRouterNamedSet_routerNamedSetPrefixExample [Debug log]
TestAccComputeRouterNamedSet_routerNamedSetRoutePolicyExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1370
Passed tests: 1277
Skipped tests: 90
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterNamedSet_routerNamedSetCommunityExample
  • TestAccComputeRouterNamedSet_routerNamedSetPrefixExample
  • TestAccComputeRouterNamedSet_routerNamedSetRoutePolicyExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterNamedSet_routerNamedSetCommunityExample [Debug log]
TestAccComputeRouterNamedSet_routerNamedSetPrefixExample [Debug log]
TestAccComputeRouterNamedSet_routerNamedSetRoutePolicyExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Contributor

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good -- just some nits

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 427 insertions(+))
google-beta provider: Diff ( 6 files changed, 1447 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 223 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_router_named_set (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_named_set" "primary" {
  elements {
    location = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_router_named_set

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1371
Passed tests: 1280
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterNamedSet_updatePrefixExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeRouterNamedSet_updatePrefixExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 427 insertions(+))
google-beta provider: Diff ( 6 files changed, 1447 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 223 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_router_named_set (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_named_set" "primary" {
  elements {
    location = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_router_named_set

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1371
Passed tests: 1280
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterNamedSet_updatePrefixExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterNamedSet_updatePrefixExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 466 insertions(+))
google-beta provider: Diff ( 6 files changed, 1486 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 223 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_router_named_set (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_named_set" "primary" {
  elements {
    location = # value needed
  }
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_compute_router_named_set

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1371
Passed tests: 1281
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 309 insertions(+))
google-beta provider: Diff ( 6 files changed, 1486 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 223 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_router_named_set (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_named_set" "primary" {
  elements {
    location = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1376
Passed tests: 1285
Skipped tests: 90
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRouterNamedSet_updatePrefix

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterNamedSet_updatePrefix [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from ScottSuarez March 4, 2026 05:17
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 309 insertions(+))
google-beta provider: Diff ( 6 files changed, 1529 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 223 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_router_named_set (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_router_named_set" "primary" {
  elements {
    location = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1376
Passed tests: 1286
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

@ScottSuarez ScottSuarez added this pull request to the merge queue Mar 4, 2026
Merged via the queue into GoogleCloudPlatform:main with commit e867621 Mar 4, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants