gkehub: Fix TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController

[BBBmau]

We've been seeing consistent failures when looking at nightly-tests:

=== CONT  TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController
    resource_gke_hub_feature_membership_test.go:949: Step 3/6 error: After applying this test step, the plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_gke_hub_feature_membership.feature_member will be updated in-place
          ~ resource "google_gke_hub_feature_membership" "feature_member" {
                id                  = "projects/tf-test-gkehub4u4h8qe4f1/locations/global/features/policycontroller/membershipId/tf-test14u4h8qe4f1"
                # (5 unchanged attributes hidden)
              ~ policycontroller {
                    # (1 unchanged attribute hidden)
                  ~ policy_controller_hub_config {
                      - audit_interval_seconds     = 60 -> null
                        # (6 unchanged attributes hidden)
                        # (4 unchanged blocks hidden)
                    }
                }
            }
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController (1205.07s)

It appears that the value audit-interval_seconds has a default value set by the api when no value is set. Because of this we get a plan not empty after the third step configuration is applied due to the configuration not containing a value set on audit_interval_second

We should see a passing VCR test on TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field policycontroller.policy_controller_hub_config.audit_interval_seconds default value changed from <nil> to 60 on google_gke_hub_feature_membership - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[BBBmau]

Addressing the breaking change comment, this wouldn't be a breaking change as it already performs the default set on the API side. I don't think we have the ability to set Computed override on DCL resources. I can look into adding this in if we choose not to go with a client-side default value

[rileykarson]

Suggested change

	- type: CUSTOM_DEFAULT
	field: policycontroller.policy_controller_hub_config.audit_interval_seconds
	details:
	default: 60
	- type: CUSTOM_SCHEMA_VALUES
	field: policycontroller.policy_controller_hub_config.audit_interval_seconds
	details:
	computed: true

I may have that syntax wrong, but that's roughly what we need for O+C I think! tpgtools was very literal about replacements of things in overrides, since we'd have expected to make most nontrivial changes against the DCL itself.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 8 insertions(+), 9 deletions(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field policycontroller.policy_controller_hub_config.audit_interval_seconds became Computed only on google_gke_hub_feature_membership - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Oh wait- tpgtools funniness

[rileykarson]

You'll additionally want to apply these changes to https://github.com/BBBmau/magic-modules/blob/3436f62e6e4007ee874d78eb4c02e1731979f200/tpgtools/overrides/gkehub/beta/feature_membership.yaml

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 2 files changed, 3 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 11
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• gkehub

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccGKEHubFeatureMembership_gkehubFeaturePolicyController [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test