Compute: Add storage_pool support to instance template disks

[yihanl-google]

Adds support for the 'storage_pool' attribute within the 'disk' block for both google_compute_instance_template and
google_compute_region_instance_template resources.

Includes acceptance tests for both resources.

The following acceptance tests: TestAccComputeInstanceTemplate_storagePool and TestAccComputeRegionInstanceTemplate_storagePool have been executed successfully.

Fixes b/475522051

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `storage_pool` support to `google_compute_instance_template` and `google_compute_region_instance_template` disks

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[yihanl-google]

Hi @melinath, friendly ping on this when you have a chance, thanks!

[melinath]

Looks straightforward! Tests are there, but it looks like you still need to update the docs to add the new fields:

• https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/r/compute_instance_template.html.markdown
• https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/r/compute_region_instance_template.html.markdown

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 178 insertions(+))
google-beta provider: Diff ( 6 files changed, 178 insertions(+))

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_compute_instance_template
  • Expected Document Path: /website/docs/r/compute_instance_template.html.markdown
  • Fields: [disk.storage_pool]
• google_compute_region_instance_template
  • Expected Document Path: /website/docs/r/compute_region_instance_template.html.markdown
  • Fields: [disk.storage_pool]

[modular-magician]

Tests analytics

Total tests: 1374
Passed tests: 1282
Skipped tests: 90
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceTemplate_storagePool
• TestAccComputeRegionInstanceTemplate_storagePool

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeInstanceTemplate_storagePool [Debug log]
TestAccComputeRegionInstanceTemplate_storagePool [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 189 insertions(+))
google-beta provider: Diff ( 8 files changed, 189 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1374
Passed tests: 1284
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log