[bigtable] - Add an example of a cloud function with Bigtable

[billyjacobson]

No description provided.

[fhinkel]

👋 Can you also add yourself as codeowner in the OWNERS file please.

[ace-n]

I'm -1 on mocking APIs unless absolutely necessary (mock tests may not detect client library surface changes), but other than that LGTM.

[ace-n]

Is it worth testing this directly instead of using a mocked client library?

[billyjacobson]

I don't have a strong opinion about this, I'm just following what every other sample has done.

[ace-n]

If you ask me, that's an antipattern. 🙂 We should use system tests wherever pragmatic; mocking should be reserved for situations where system tests don't work well. (E.g. when they take 5+ minutes to run.)

[fhinkel]

I agree, system tests often give us a better indication if something breaks. That being said, considering that we have lots of samples in this repo that use proxyquire, I suggest we merge this PR as it is. @billyjacobson, is it OK if somebody else revisits the tests in the future even though you're code owner?

[billyjacobson]

I agree, system tests often give us a better indication if something breaks. That being said, considering that we have lots of samples in this repo that use proxyquire, I suggest we merge this PR as it is. @billyjacobson, is it OK if somebody else revisits the tests in the future even though you're code owner?

Happy to help provide a review in the future on the tests

[ace-n]

Oh - one more thing that I almost forgot: these samples should live in bigtable/functions, not functions/bigtable.

(@grant and I previously decided that the top-level functions/ should only be for samples used in the Functions docs.)

[billyjacobson]

Oh - one more thing that I almost forgot: these samples should live in bigtable/functions, not functions/bigtable.

(@grant and I previously decided that the top-level functions/ should only be for samples used in the Functions docs.)

these will be in the functions doc and potentially the bigtable docs, just like the Spanner ones

[fhinkel]

ping @ace-n does your objection still hold with @billyjacobson 's clarification?

[ace-n]

@fhinkel I'll defer to @labtopia on that (GCF TW).

(N.B: they're quite busy with ongoing GCF asks, so they may take awhile to get to this.)

[ace-n]

FYI: chatted with @labtopia offline, we are 👎on adding these to the functions docs.

(The "spanner tutorial" you mentioned likely should either be removed entirely [given that we have this page], or moved to the spanner/ docs.)

What we are in favor of is linking out from the functions/ docs' left-nav in the same way the above-mentioned Spanner tutorial does (as shown at the bottom of this image):