Update README.md to include region#524
Closed
art-tts wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Closed
Update README.md to include region#524art-tts wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
art-tts wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
Including region in example, if you're in Europe the example will not work, and will instead spit out errors.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 13 13
Lines 458 458
=======================================
Hits 445 445
Misses 13 13Continue to review full report at Codecov.
|
Author
|
I signed it! |
gguuss
reviewed
Dec 14, 2017
| --registry_id=my-registry \ | ||
| --device_id=my-node-device \ | ||
| --private_key_file=../rsa_private.pem \ | ||
| --cloud_region=us-west1 \ |
Contributor
There was a problem hiding this comment.
Nit. I'm not 100% sure we're in the us-west1 region yet, can you change this to us-central1, europe-west1, or asia-east1?
Contributor
There was a problem hiding this comment.
I did, us-central1 is definitely supported, others I didn't list are not showing up for me.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Contributor
|
@googlebot I signed it! |
Contributor
|
@art-tts Thanks for the PR! Do you want to make the requested change? |
Contributor
|
Closing, instructions must have been updated in a separate PR. |
This was referenced Dec 23, 2020
Open
This was referenced Sep 6, 2021
This was referenced Jan 12, 2022
Open
This was referenced Feb 10, 2022
Open
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 8, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
kweinmeister
pushed a commit
that referenced
this pull request
Nov 10, 2022
Co-authored-by: Nicole Zhu <69952136+nicoleczhu@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: Nicole Zhu <69952136+nicoleczhu@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: Nicole Zhu <69952136+nicoleczhu@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.2...v2.4.3) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#526](https://www.github.com/googleapis/nodejs-automl/issues/526)) ([8911d45](https://www.github.com/googleapis/nodejs-automl/commit/8911d457513f2c0c9cca6d2b7473b314ac3a4efd)) * **deps:** require google-gax v2.17.0 ([#524](https://www.github.com/googleapis/nodejs-automl/issues/524)) ([5863c54](https://www.github.com/googleapis/nodejs-automl/commit/5863c5440bf94fa2fd986b5c8f5265b86fd4497e)) * make request optional in all cases ([#521](https://www.github.com/googleapis/nodejs-automl/issues/521)) ([a45622a](https://www.github.com/googleapis/nodejs-automl/commit/a45622a9f53683a73fd2057ef5a2ccf22e7da946)) * REST fallback client header ([#513](https://www.github.com/googleapis/nodejs-automl/issues/513)) ([833d2d7](https://www.github.com/googleapis/nodejs-automl/commit/833d2d70ff1828a69e7f9482f58189f5d484751f)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#527](https://www.github.com/googleapis/nodejs-automl/issues/527)) ([dfb504e](https://www.github.com/googleapis/nodejs-automl/commit/dfb504e12075136707e5915b1db6f65ed72d5aa9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.2...v2.4.3) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#526](https://www.github.com/googleapis/nodejs-automl/issues/526)) ([8911d45](https://www.github.com/googleapis/nodejs-automl/commit/8911d457513f2c0c9cca6d2b7473b314ac3a4efd)) * **deps:** require google-gax v2.17.0 ([#524](https://www.github.com/googleapis/nodejs-automl/issues/524)) ([5863c54](https://www.github.com/googleapis/nodejs-automl/commit/5863c5440bf94fa2fd986b5c8f5265b86fd4497e)) * make request optional in all cases ([#521](https://www.github.com/googleapis/nodejs-automl/issues/521)) ([a45622a](https://www.github.com/googleapis/nodejs-automl/commit/a45622a9f53683a73fd2057ef5a2ccf22e7da946)) * REST fallback client header ([#513](https://www.github.com/googleapis/nodejs-automl/issues/513)) ([833d2d7](https://www.github.com/googleapis/nodejs-automl/commit/833d2d70ff1828a69e7f9482f58189f5d484751f)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#527](https://www.github.com/googleapis/nodejs-automl/issues/527)) ([dfb504e](https://www.github.com/googleapis/nodejs-automl/commit/dfb504e12075136707e5915b1db6f65ed72d5aa9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.1](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.0...v2.4.1) (2020-11-25) ### Bug Fixes * skip tests for now ([#523](https://www.github.com/googleapis/nodejs-compute/issues/523)) ([f0f8fae](https://www.github.com/googleapis/nodejs-compute/commit/f0f8faee962b5463b26c7551adae67a724875a55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.2...v2.4.3) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#526](https://www.github.com/googleapis/nodejs-automl/issues/526)) ([8911d45](https://www.github.com/googleapis/nodejs-automl/commit/8911d457513f2c0c9cca6d2b7473b314ac3a4efd)) * **deps:** require google-gax v2.17.0 ([#524](https://www.github.com/googleapis/nodejs-automl/issues/524)) ([5863c54](https://www.github.com/googleapis/nodejs-automl/commit/5863c5440bf94fa2fd986b5c8f5265b86fd4497e)) * make request optional in all cases ([#521](https://www.github.com/googleapis/nodejs-automl/issues/521)) ([a45622a](https://www.github.com/googleapis/nodejs-automl/commit/a45622a9f53683a73fd2057ef5a2ccf22e7da946)) * REST fallback client header ([#513](https://www.github.com/googleapis/nodejs-automl/issues/513)) ([833d2d7](https://www.github.com/googleapis/nodejs-automl/commit/833d2d70ff1828a69e7f9482f58189f5d484751f)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#527](https://www.github.com/googleapis/nodejs-automl/issues/527)) ([dfb504e](https://www.github.com/googleapis/nodejs-automl/commit/dfb504e12075136707e5915b1db6f65ed72d5aa9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 15, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.2...v2.4.3) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#526](https://www.github.com/googleapis/nodejs-automl/issues/526)) ([8911d45](https://www.github.com/googleapis/nodejs-automl/commit/8911d457513f2c0c9cca6d2b7473b314ac3a4efd)) * **deps:** require google-gax v2.17.0 ([#524](https://www.github.com/googleapis/nodejs-automl/issues/524)) ([5863c54](https://www.github.com/googleapis/nodejs-automl/commit/5863c5440bf94fa2fd986b5c8f5265b86fd4497e)) * make request optional in all cases ([#521](https://www.github.com/googleapis/nodejs-automl/issues/521)) ([a45622a](https://www.github.com/googleapis/nodejs-automl/commit/a45622a9f53683a73fd2057ef5a2ccf22e7da946)) * REST fallback client header ([#513](https://www.github.com/googleapis/nodejs-automl/issues/513)) ([833d2d7](https://www.github.com/googleapis/nodejs-automl/commit/833d2d70ff1828a69e7f9482f58189f5d484751f)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#527](https://www.github.com/googleapis/nodejs-automl/issues/527)) ([dfb504e](https://www.github.com/googleapis/nodejs-automl/commit/dfb504e12075136707e5915b1db6f65ed72d5aa9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 15, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.2...v2.4.3) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#526](https://www.github.com/googleapis/nodejs-automl/issues/526)) ([8911d45](https://www.github.com/googleapis/nodejs-automl/commit/8911d457513f2c0c9cca6d2b7473b314ac3a4efd)) * **deps:** require google-gax v2.17.0 ([#524](https://www.github.com/googleapis/nodejs-automl/issues/524)) ([5863c54](https://www.github.com/googleapis/nodejs-automl/commit/5863c5440bf94fa2fd986b5c8f5265b86fd4497e)) * make request optional in all cases ([#521](https://www.github.com/googleapis/nodejs-automl/issues/521)) ([a45622a](https://www.github.com/googleapis/nodejs-automl/commit/a45622a9f53683a73fd2057ef5a2ccf22e7da946)) * REST fallback client header ([#513](https://www.github.com/googleapis/nodejs-automl/issues/513)) ([833d2d7](https://www.github.com/googleapis/nodejs-automl/commit/833d2d70ff1828a69e7f9482f58189f5d484751f)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#527](https://www.github.com/googleapis/nodejs-automl/issues/527)) ([dfb504e](https://www.github.com/googleapis/nodejs-automl/commit/dfb504e12075136707e5915b1db6f65ed72d5aa9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.2...v2.4.3) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#526](https://www.github.com/googleapis/nodejs-automl/issues/526)) ([8911d45](https://www.github.com/googleapis/nodejs-automl/commit/8911d457513f2c0c9cca6d2b7473b314ac3a4efd)) * **deps:** require google-gax v2.17.0 ([#524](https://www.github.com/googleapis/nodejs-automl/issues/524)) ([5863c54](https://www.github.com/googleapis/nodejs-automl/commit/5863c5440bf94fa2fd986b5c8f5265b86fd4497e)) * make request optional in all cases ([#521](https://www.github.com/googleapis/nodejs-automl/issues/521)) ([a45622a](https://www.github.com/googleapis/nodejs-automl/commit/a45622a9f53683a73fd2057ef5a2ccf22e7da946)) * REST fallback client header ([#513](https://www.github.com/googleapis/nodejs-automl/issues/513)) ([833d2d7](https://www.github.com/googleapis/nodejs-automl/commit/833d2d70ff1828a69e7f9482f58189f5d484751f)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#527](https://www.github.com/googleapis/nodejs-automl/issues/527)) ([dfb504e](https://www.github.com/googleapis/nodejs-automl/commit/dfb504e12075136707e5915b1db6f65ed72d5aa9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.2...v2.4.3) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#526](https://www.github.com/googleapis/nodejs-automl/issues/526)) ([8911d45](https://www.github.com/googleapis/nodejs-automl/commit/8911d457513f2c0c9cca6d2b7473b314ac3a4efd)) * **deps:** require google-gax v2.17.0 ([#524](https://www.github.com/googleapis/nodejs-automl/issues/524)) ([5863c54](https://www.github.com/googleapis/nodejs-automl/commit/5863c5440bf94fa2fd986b5c8f5265b86fd4497e)) * make request optional in all cases ([#521](https://www.github.com/googleapis/nodejs-automl/issues/521)) ([a45622a](https://www.github.com/googleapis/nodejs-automl/commit/a45622a9f53683a73fd2057ef5a2ccf22e7da946)) * REST fallback client header ([#513](https://www.github.com/googleapis/nodejs-automl/issues/513)) ([833d2d7](https://www.github.com/googleapis/nodejs-automl/commit/833d2d70ff1828a69e7f9482f58189f5d484751f)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#527](https://www.github.com/googleapis/nodejs-automl/issues/527)) ([dfb504e](https://www.github.com/googleapis/nodejs-automl/commit/dfb504e12075136707e5915b1db6f65ed72d5aa9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.3](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.2...v2.4.3) (2021-07-21) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#526](https://www.github.com/googleapis/nodejs-automl/issues/526)) ([8911d45](https://www.github.com/googleapis/nodejs-automl/commit/8911d457513f2c0c9cca6d2b7473b314ac3a4efd)) * **deps:** require google-gax v2.17.0 ([#524](https://www.github.com/googleapis/nodejs-automl/issues/524)) ([5863c54](https://www.github.com/googleapis/nodejs-automl/commit/5863c5440bf94fa2fd986b5c8f5265b86fd4497e)) * make request optional in all cases ([#521](https://www.github.com/googleapis/nodejs-automl/issues/521)) ([a45622a](https://www.github.com/googleapis/nodejs-automl/commit/a45622a9f53683a73fd2057ef5a2ccf22e7da946)) * REST fallback client header ([#513](https://www.github.com/googleapis/nodejs-automl/issues/513)) ([833d2d7](https://www.github.com/googleapis/nodejs-automl/commit/833d2d70ff1828a69e7f9482f58189f5d484751f)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#527](https://www.github.com/googleapis/nodejs-automl/issues/527)) ([dfb504e](https://www.github.com/googleapis/nodejs-automl/commit/dfb504e12075136707e5915b1db6f65ed72d5aa9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.4](https://www.github.com/googleapis/nodejs-dataproc/compare/v2.4.3...v2.4.4) (2021-08-17) ### Bug Fixes * **build:** migrate to using main branch ([#523](https://www.github.com/googleapis/nodejs-dataproc/issues/523)) ([42b4163](https://www.github.com/googleapis/nodejs-dataproc/commit/42b4163483409a29740878f95cabf2ce617bfa86)) * **deps:** google-gax v2.24.1 ([#524](https://www.github.com/googleapis/nodejs-dataproc/issues/524)) ([fa82a3a](https://www.github.com/googleapis/nodejs-dataproc/commit/fa82a3a8864de5f88ce4d28445cdc85837413ee3)) * **deps:** require google-gax v2.17.1 ([#510](https://www.github.com/googleapis/nodejs-dataproc/issues/510)) ([4706b61](https://www.github.com/googleapis/nodejs-dataproc/commit/4706b61bf928f0c6e7a2c811ff203d82da8fa2a1)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#511](https://www.github.com/googleapis/nodejs-dataproc/issues/511)) ([be8cecc](https://www.github.com/googleapis/nodejs-dataproc/commit/be8ceccc36ffa198f983b78ae7918af43d291f42)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay
pushed a commit
that referenced
this pull request
Nov 19, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.4](https://www.github.com/googleapis/nodejs-dataproc/compare/v2.4.3...v2.4.4) (2021-08-17) ### Bug Fixes * **build:** migrate to using main branch ([#523](https://www.github.com/googleapis/nodejs-dataproc/issues/523)) ([42b4163](https://www.github.com/googleapis/nodejs-dataproc/commit/42b4163483409a29740878f95cabf2ce617bfa86)) * **deps:** google-gax v2.24.1 ([#524](https://www.github.com/googleapis/nodejs-dataproc/issues/524)) ([fa82a3a](https://www.github.com/googleapis/nodejs-dataproc/commit/fa82a3a8864de5f88ce4d28445cdc85837413ee3)) * **deps:** require google-gax v2.17.1 ([#510](https://www.github.com/googleapis/nodejs-dataproc/issues/510)) ([4706b61](https://www.github.com/googleapis/nodejs-dataproc/commit/4706b61bf928f0c6e7a2c811ff203d82da8fa2a1)) * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#511](https://www.github.com/googleapis/nodejs-dataproc/issues/511)) ([be8cecc](https://www.github.com/googleapis/nodejs-dataproc/commit/be8ceccc36ffa198f983b78ae7918af43d291f42)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.1](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.0...v2.4.1) (2020-11-25) ### Bug Fixes * skip tests for now ([#523](https://www.github.com/googleapis/nodejs-compute/issues/523)) ([f0f8fae](https://www.github.com/googleapis/nodejs-compute/commit/f0f8faee962b5463b26c7551adae67a724875a55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.1](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.0...v2.4.1) (2020-11-25) ### Bug Fixes * skip tests for now ([#523](https://www.github.com/googleapis/nodejs-compute/issues/523)) ([f0f8fae](https://www.github.com/googleapis/nodejs-compute/commit/f0f8faee962b5463b26c7551adae67a724875a55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including region in example, if you're in Europe the example will not work, and will instead spit out errors.