Skip to content

feat: support info metrics#267

Merged
bernot-dev merged 4 commits intorelease-2.53.5-gmpfrom
info-metrics
Feb 11, 2026
Merged

feat: support info metrics#267
bernot-dev merged 4 commits intorelease-2.53.5-gmpfrom
info-metrics

Conversation

@bernot-dev
Copy link
Copy Markdown
Collaborator

Add support for INFO metrics by converting them to Gauges.

@bernot-dev bernot-dev requested a review from bwplotka November 24, 2025 18:29
@bernot-dev bernot-dev self-assigned this Nov 24, 2025
@bernot-dev bernot-dev requested a review from dashpole November 24, 2025 19:06
@bernot-dev bernot-dev marked this pull request as ready for review November 24, 2025 19:06
Copy link
Copy Markdown
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's generally should be it, but also test will tell us more.

I'd recommend adding one to https://github.com/GoogleCloudPlatform/prometheus/blob/release-2.53.5-gmp/google/internal/promqle2etest/gcm_test.go

Since SDK does not support info metrics you might need some slight change in how we setup test framework to inject custom text format 🤔 that might be the main work here. If I were you I would attempt to extend (you are welcome to contribute too!) https://github.com/prometheus/compliance/blob/7667b56d892fbb4f4252287e50bbad6d2a8f6893/promqle2e/promqle2e.go#L435 so it accepts []string with OpenMetrics raw TEXT to show (and change) on every scrape and expect some result.

This would benefit the promqle2e and our environment, but if you find a different way to test this (e.g. extending our side local export GCM helper:

func (l *runningLocalExportWithGCM) IngestSamples(ctx context.Context, t testing.TB, recorded [][]*dto.MetricFamily) {
)

ghost

This comment was marked as spam.

@bernot-dev bernot-dev requested a review from bwplotka February 11, 2026 17:08
Copy link
Copy Markdown
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

LGTM, modulo tiny commentary nits (keep it a full English sentence, please).

I wished we could test it e2e with GCM, but this is good enough, we can do e2e test later and manually deploy latest GMP with KSM with info metric.

Added: #281

@bwplotka
Copy link
Copy Markdown
Collaborator

NOTE: Same work is needed for stateset, but low prio.

bernot-dev and others added 2 commits February 11, 2026 10:31
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bernot-dev bernot-dev merged commit fbe95de into release-2.53.5-gmp Feb 11, 2026
5 checks passed
@bernot-dev bernot-dev deleted the info-metrics branch March 2, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants