Skip to content

fix: aws batch load job definition revision#2125

Open
kmingwww wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
kmingwww:fix/aws-batch-load-job-definition
Open

fix: aws batch load job definition revision#2125
kmingwww wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
kmingwww:fix/aws-batch-load-job-definition

Conversation

@kmingwww
Copy link

Related to: #2124

Root Cause

jobDefinitionName := StringValue(jobDefinition.JobDefinitionName) + ":" + fmt.Sprint(jobDefinition.Revision)

  • jobDefinition.Revision is not a simple string or integer. In the AWS SDK for Go, the Revision field within the JobDefinition struct is likely a pointer to an integer (*int64) or another complex type. It's not just a simple value.

  • fmt.Sprint()'s default behavior for pointers. When you use fmt.Sprint() on a pointer or a struct that doesn't have a specific String() method defined, Go's default behavior is to print the memory address where that object is stored. Memory addresses are conventionally represented in hexadecimal format.

Fix

// Incorrect (what's currently there)
jobDefinitionName := StringValue(jobDefinition.JobDefinitionName) + ":" + fmt.Sprint(jobDefinition.Revision)

// Corrected version
jobDefinitionName := StringValue(jobDefinition.JobDefinitionName) + ":" + fmt.Sprint(*jobDefinition.Revision) // Note the *

@google-cla
Copy link

google-cla bot commented Jan 15, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kmingwww kmingwww force-pushed the fix/aws-batch-load-job-definition branch from 8ec40fe to 8f6af14 Compare January 15, 2026 10:31
@kmingwww kmingwww force-pushed the fix/aws-batch-load-job-definition branch from 8f6af14 to 14fcec8 Compare January 15, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant