fix: aws batch load job definition revision#2125
Open
kmingwww wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Open
fix: aws batch load job definition revision#2125kmingwww wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
kmingwww wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
8ec40fe to
8f6af14
Compare
8f6af14 to
14fcec8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #2124
Root Cause
terraformer/providers/aws/batch.go
Line 76 in 069060c
jobDefinition.Revision is not a simple string or integer. In the AWS SDK for Go, the Revision field within the JobDefinition struct is likely a pointer to an integer (*int64) or another complex type. It's not just a simple value.
fmt.Sprint()'s default behavior for pointers. When you use fmt.Sprint() on a pointer or a struct that doesn't have a specific String() method defined, Go's default behavior is to print the memory address where that object is stored. Memory addresses are conventionally represented in hexadecimal format.
Fix