-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add nodejs20 #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nodejs20 #1297
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@omBratteng any comments here? You've been super helpful with the node images. Should we also remove nodejs14 (Looks like that is going out of security support in a week?) |
|
Node.js 14 will have its end-of-life date on April 30, so #1298 should be merged after that, by the way. |
|
Unfortunately the docker based examples expect existence, so that needs to be updated after this. |
|
OK, then let me just split the PR 🙃 |
|
An update for the Node.js official image can be found here nodejs/docker-node#1882, I will track that and send you a ping in the PR for an example update as needed. |
Signed-off-by: Sora Morimoto <[email protected]>
Looks good to me. And yeah, we could remove nodejs14, I doubt there's going to be a version update for it before to 30th, but waiting till then doesn't hurt. |
|
Thanks @smorimoto for the contribution. |
|
The should be published automatically within a few hours. |
|
|
||
| node_archive( | ||
| name = "nodejs20_arm64", | ||
| sha256 = "997ddc7ca941280aeb357d4ad40ea7f93cb4d7989b93056dbf1b42a1a89b449b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrmm these checksums appear to be wrong, I don't know why CI didn't pick this up?
|
Hmm 🧐 that’s pretty weird… Sorry for disturbing you 😑 |
|
No it's okay. It means our ci checks are incomplete |
https://nodejs.org/en/blog/release/v20.0.0