Skip to content

Conversation

@smorimoto
Copy link
Contributor

@google-cla
Copy link

google-cla bot commented Apr 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@loosebazooka
Copy link
Member

@omBratteng any comments here? You've been super helpful with the node images. Should we also remove nodejs14 (Looks like that is going out of security support in a week?)

@smorimoto
Copy link
Contributor Author

Node.js 14 will have its end-of-life date on April 30, so #1298 should be merged after that, by the way.

@loosebazooka
Copy link
Member

Unfortunately the docker based examples expect existence, so that needs to be updated after this.

@smorimoto
Copy link
Contributor Author

OK, then let me just split the PR 🙃

@smorimoto
Copy link
Contributor Author

An update for the Node.js official image can be found here nodejs/docker-node#1882, I will track that and send you a ping in the PR for an example update as needed.

Signed-off-by: Sora Morimoto <[email protected]>
@omBratteng
Copy link
Collaborator

@omBratteng any comments here? You've been super helpful with the node images. Should we also remove nodejs14 (Looks like that is going out of security support in a week?)

Looks good to me. And yeah, we could remove nodejs14, I doubt there's going to be a version update for it before to 30th, but waiting till then doesn't hurt.

@loosebazooka
Copy link
Member

Thanks @smorimoto for the contribution.

@loosebazooka loosebazooka merged commit e9b12a0 into GoogleContainerTools:main Apr 18, 2023
@loosebazooka
Copy link
Member

The should be published automatically within a few hours.


node_archive(
name = "nodejs20_arm64",
sha256 = "997ddc7ca941280aeb357d4ad40ea7f93cb4d7989b93056dbf1b42a1a89b449b",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrmm these checksums appear to be wrong, I don't know why CI didn't pick this up?

@smorimoto smorimoto deleted the node20 branch April 19, 2023 01:19
@smorimoto
Copy link
Contributor Author

Hmm 🧐 that’s pretty weird… Sorry for disturbing you 😑

@loosebazooka
Copy link
Member

No it's okay. It means our ci checks are incomplete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants