Open
Conversation
added 17 commits
April 9, 2017 09:42
publish new email images
Contributor
Author
|
This pull request refers to the work I have done for Trello Integration inside Teem! I will also be writing a couple of readme files here for more information! |
atfornes
reviewed
Aug 27, 2017
src/js/services/trelloService.js
Outdated
|
|
||
| function archiveCard(trelloObj, need){ | ||
| let deferred = $q.defer(); | ||
| const archiveCardURL = `https://api.trello.com/1/cards/${need.trelloId}?closed="true"&key=09e4aced60041e389dbb27b9accadd65&token=${trelloObj.token}`; |
There was a problem hiding this comment.
key should go to the configuration file, and now be changed probably. Please let me know the new key so I can add it to the secrets file to be used by travis.
src/js/services/trelloService.js
Outdated
| } | ||
|
|
||
| function registerWebhook(trelloObj){ | ||
| const webhookURL = `https://api.trello.com/1/webhooks/?idModel=${trelloObj.boardId}&key=09e4aced60041e389dbb27b9accadd65&token=${trelloObj.token}&callbackURL=http://13.126.145.126:9000/`; |
|
When trying to add tasks using this code, either empty or preselecting some text I get the following error: comming from line: https://github.com/Grasia/teem/blob/master/src/js/services/pad/need-widget.js#L39 This commit does not touch that line,but somehow broke the behaviour. Please have a look to see if the issue can be fixed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.