Conversation
JoshuaBehrens
left a comment
JoshuaBehrens
left a comment
There was a problem hiding this comment.
I like the feature. Reminds me of shopware/shopware#474 . With that in mind there are some concerns about admin user data in the media storage. This will need a configuration on client level to control.
src/Service/UserResolver.php
Outdated
| $this->mediaUploadService->uploadFromLocalPath( | ||
| $tempFile, | ||
| $context, | ||
| new MediaUploadParameters(id: $avatarId, fileName: $avatarId . '.jpg') |
There was a problem hiding this comment.
This is too much determined to be a jpg. Could be webp or png as well. Maybe the mime from the response can be forwarded here
There was a problem hiding this comment.
uhhh, you are absolute correct with the format. I thought of it while checking its possiblities and then forgot it.
With configuration on client level you mean toggle for import picture if available?
There was a problem hiding this comment.
Yes exactly. This has to be optional and needs to be opt-in as it changes behaviour
There was a problem hiding this comment.
@JoshuaBehrens Ready.
I just set the config to the default and Microsoft OIDC due to missing possiblities to test.
If you think, this should be fine, while it just follows OIDC rules, I can adopt it to the other OIDC providers.
2 participants
Closes #51