Personal/valverlu/master#2
Open
luis-valverde wants to merge 6 commits intoHPENetworking:bindingsfrom
luis-valverde:personal/valverlu/master
Open
Personal/valverlu/master#2luis-valverde wants to merge 6 commits intoHPENetworking:bindingsfrom luis-valverde:personal/valverlu/master
luis-valverde wants to merge 6 commits intoHPENetworking:bindingsfrom
luis-valverde:personal/valverlu/master
Conversation
added 3 commits
January 14, 2016 23:26
Migration of libviface C++ library to C code. It includes several examples and a test program to verify the functionality.
Fix build system to compile libviface C library and bindings (currently C++). Some targets were added in the autogenerated makefiles to choose the library to compile or install. For example: make, make libviface, make libvifacecpp, make install libviface.
Incorporate code review comments suggested by Carlos Jenkins to stick with the guidelines styles.
added 3 commits
February 10, 2016 11:37
Change data types of some input parameters and logic methods to make it work with the GO wrapper and avoid APR dependencies from GO code.
Creation of a libviface wrapper in GO language. It includes the wrapper GO code and some basic usage examples.
Fix build system to compile libviface GO wrapper and examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code review includes:
For example: make, make libviface, make install libviface, make doc, make libvifacecpp.