New selectors for like and dislike buttons, plus for shorts#33
New selectors for like and dislike buttons, plus for shorts#33kas-cor wants to merge 1 commit intoHatScripts:masterfrom
Conversation
|
For the Shorts subscribe button, instead of testing for a class, we could test for the 'subscribed' attribute on the const subscribed = subscribeButton.hasAttribute('subscribe-button-invisible') || subscribeButton.hasAttribute('subscribed')The selector for the subscribe button would then be: SUBSCRIBE_BUTTON: '#subscribe-button > ytd-subscribe-button-renderer, ytd-reel-player-overlay-renderer #subscribe-button',In my opinion, this is makes both the subscribe check and the selector cleaner and not dependent on the style of the UI. |
|
For the like/dislike button selectors, I made a similar change in #32, except, because there are two results for each button with those selectors, I think it may be necessary to be more specific due to issues raised in #17. Your change also removes LIKE_BUTTON: '#menu .YtLikeButtonViewModelHost button, #segmented-like-button button, #like-button button'... and likewise for the dislike button: DISLIKE_BUTTON: '#menu .YtDislikeButtonViewModelHost button, #segmented-dislike-button button, #dislike-button button'These combined changes would also fix #30 |
|
@BleakBluets I've implemented your suggestions (9ea38ad)! Thank you |
|
Oh finally a script that works 😍😍 |
|
@riccardosimo Could you please create a new issue for the feature request you are describing? And please elaborate on:
|
No description provided.