Open
Conversation
Previously crn_decompile.h made several assumptions that no longer holds on 64-bit platform and thus will cause a compilation error. More specifically: It assumes that pointers are 4 bytes long, while on 64-bit pointers are 8 bytes long. It assumes (unsigned) long and (u)int64 are different types, while on many 64-bit implementations they are the same. This commit fixes those problem by changing multiple typedefs from using built-in integer types to typedefs in <cstdint>, and make pointers cast to std::uintptr_t rather than uint32. This should ensure successful compilation on both 32-bit and 64-bit platforms.
|
Thank you. This fixes the same error in HearthSim/UnityPack#97 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously crn_decompile.h made several assumptions that no longer holds
on 64-bit platform and thus will cause a compilation error. More
specifically:
It assumes that pointers are 4 bytes long, while on 64-bit pointers
are 8 bytes long.
It assumes (unsigned) long and (u)int64 are different types, while on
many 64-bit implementations they are the same.
This commit fixes those problem by changing multiple typedefs from using
built-in integer types to typedefs in , and make pointers cast
to std::uintptr_t rather than uint32. This should ensure successful
compilation on both 32-bit and 64-bit platforms.
fixes #6