Image element created#226
Image element created#226jmcasimar wants to merge 3 commits intoHieromon:masterfrom jmcasimar:ImageElement_base64
Conversation
|
The latest commit actually allows add an image encoded as base64 string to header menu in the left corner. The example sketch creates 2 images:
This code has some limitations, for example the image in the header by now is fixed to 60x60, this works when the aspect ratio of the image is 1:1 but it can be easily defined as a new AutoConnectConfig property. Also the title of the menu is moved to the center by the image, I think that this aspect could be much better, but this shows that is possible to solve #208 |
|
Thank you for the PR.
|
|
Thanks for your time to test it, All the time I knew that memory could be a problem because base64 generates too large strings. At first, I made this PR knowing that my methods would be poor in stability and perfomance. I´m relatively new in C++ and there are some parts of the code that I do not understand yet, but I made the PR for 2 reason:
With that in mind, I share your view about the PR. I do not even know what AutoConnectElement is capable to do. I do not have enough time as I would like, but I will continue working on it. |

This is my first proposal to solve #208
I am working to add dynamically an image to the header, but is not ready yet.