Skip to content

Dwk/dev#6

Merged
timholy merged 2 commits into
masterfrom
dwk/dev
Feb 19, 2019
Merged

Dwk/dev#6
timholy merged 2 commits into
masterfrom
dwk/dev

Conversation

@kdw503

@kdw503 kdw503 commented Feb 14, 2019

Copy link
Copy Markdown
Member

No description provided.

@timholy timholy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work!

Comment thread test/register_optimize.jl
end


# # With composition

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these already commented out elsewhere? If not, we can use @test_broken for broken tests.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You means 'With-composition' parts?
There parts were already commented out in 'BlockRegistration' packages.

@timholy timholy merged commit af37828 into master Feb 19, 2019
@timholy timholy deleted the dwk/dev branch February 19, 2019 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants