Skip to content

zeek: Enable building of JavaScript integration#262992

Merged
BrewTestBot merged 2 commits intoHomebrew:mainfrom
bbannier:t/zeek-js
Feb 13, 2026
Merged

zeek: Enable building of JavaScript integration#262992
BrewTestBot merged 2 commits intoHomebrew:mainfrom
bbannier:t/zeek-js

Conversation

@bbannier
Copy link
Contributor

With #256036 node now installs its shared library as well. If available the library is detected by the Zeek build to enable Zeek's JavaScript integration, and this patch makes the integration available deterministically.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue labels Jan 15, 2026
@bbannier bbannier marked this pull request as ready for review January 16, 2026 08:59
@daeho-ro
Copy link
Member

Isn't it a build dependency? and also want to know node version 25 can be used or not.

@bbannier
Copy link
Contributor Author

Thanks for taking a look @daeho-ro.

Isn't it a build dependency?

The formula needs it both as a build dependency to pull in headers, and runtime dependency since the zeek executable will link libnode dynamically.

and also want to know node version 25 can be used or not.

I tried an unpinned node dependency first. This failed on e.g., macos-14 since the node-25 headers use C++20 features not available with the system compiler. I can switch this to use a Homebrew-managed clang instead, but I figured just depending on node@24 would be a lighter approach.

@bbannier
Copy link
Contributor Author

@daeho-ro Does that makes sense, or do you want me to switch the formula to compilation with clang so it can depend on an unpinned node?

@bbannier
Copy link
Contributor Author

bbannier commented Feb 9, 2026

Is there anything I can do to get this moved forward?

@bbannier bbannier force-pushed the t/zeek-js branch 3 times, most recently from b03c45e to 3c0ab18 Compare February 11, 2026 17:40
With Homebrew#256036 node now installs its shared library as well. If available
the library is detected by the Zeek build to enable Zeek's JavaScript
integration, and this patch makes the integration available
deterministically.
@bbannier
Copy link
Contributor Author

bbannier commented Feb 12, 2026

@daeho-ro sorry for the direct ping. Can you tell me what else would be needed here to get this unblocked?

The way the formula is currently in main, Zeek's JavaScript feature will not be consistently available (I suspect this has to do with whether some other job left node on the bottle build host).

Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now, and sorry for late response I was busy on company things and just forgot this.

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 13, 2026
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 13, 2026
Merged via the queue into Homebrew:main with commit d585927 Feb 13, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. nodejs Node or npm use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants