zeek: Enable building of JavaScript integration#262992
zeek: Enable building of JavaScript integration#262992BrewTestBot merged 2 commits intoHomebrew:mainfrom
Conversation
|
Isn't it a build dependency? and also want to know |
|
Thanks for taking a look @daeho-ro.
The formula needs it both as a build dependency to pull in headers, and runtime dependency since the
I tried an unpinned |
|
@daeho-ro Does that makes sense, or do you want me to switch the formula to compilation with clang so it can depend on an unpinned |
|
Is there anything I can do to get this moved forward? |
b03c45e to
3c0ab18
Compare
With Homebrew#256036 node now installs its shared library as well. If available the library is detected by the Zeek build to enable Zeek's JavaScript integration, and this patch makes the integration available deterministically.
|
@daeho-ro sorry for the direct ping. Can you tell me what else would be needed here to get this unblocked? The way the formula is currently in |
daeho-ro
left a comment
There was a problem hiding this comment.
I think this is fine for now, and sorry for late response I was busy on company things and just forgot this.
|
🤖 An automated task has requested bottles to be published to this PR. Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
With #256036 node now installs its shared library as well. If available the library is detected by the Zeek build to enable Zeek's JavaScript integration, and this patch makes the integration available deterministically.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?