Skip to content

Add files.getUploadURLExternal method#342

Merged
jaredstehler merged 14 commits into
masterfrom
add-new-files-get-upload-url-external
May 15, 2024
Merged

Add files.getUploadURLExternal method#342
jaredstehler merged 14 commits into
masterfrom
add-new-files-get-upload-url-external

Conversation

@ykaliukh
Copy link
Copy Markdown
Contributor

@ykaliukh ykaliukh commented May 9, 2024

I am adding a new Slack method files.getUploadURLExternal that was recently added by Slack

@ykaliukh
Copy link
Copy Markdown
Contributor Author

@ViktorPelepiak @zmarushchak-hs Oleh (can't find you here) please take a look

Copy link
Copy Markdown

@kubayof kubayof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

views_push(MethodWriteMode.WRITE, RateLimitingTiers.TIER_4, JsonStatus.ACCEPTS_JSON),
views_publish(MethodWriteMode.WRITE, RateLimitingTiers.TIER_4, JsonStatus.ACCEPTS_JSON);
views_publish(MethodWriteMode.WRITE, RateLimitingTiers.TIER_4, JsonStatus.ACCEPTS_JSON),
files_getUploadURLExternal(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be sorted? or would that cause a breaking enum ordinal change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted

breaking enum ordinal change

I do not think it is a problem here

@jaredstehler jaredstehler merged commit 7f0725b into master May 15, 2024
@jaredstehler jaredstehler deleted the add-new-files-get-upload-url-external branch May 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants