Skip to content

Add file info method to retrieve all file info#359

Merged
opaliukh merged 6 commits into
masterfrom
add-file-info-method
Oct 14, 2024
Merged

Add file info method to retrieve all file info#359
opaliukh merged 6 commits into
masterfrom
add-file-info-method

Conversation

@opaliukh
Copy link
Copy Markdown
Contributor

@opaliukh opaliukh commented Oct 11, 2024

Add file info method to retrieve all file info

Copy link
Copy Markdown

@kubayof kubayof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@ykaliukh ykaliukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Maybe it is better to rename models because we only get 1 file. FilesInfoParamsIF -> FileInfoParamsIF

@kubayof
Copy link
Copy Markdown

kubayof commented Oct 13, 2024

LGTM! Maybe it is better to rename models because we only get 1 file. FilesInfoParamsIF -> FileInfoParamsIF

I thought the names are derived from the api method name, from this repository: users.info -> UsersInfoParams - this returns 1 user as well

@opaliukh opaliukh merged commit 1cb0cfb into master Oct 14, 2024
@opaliukh opaliukh deleted the add-file-info-method branch October 14, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants