fix: FIT-1297: Guard async operations against destroyed store #9263
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selectHistory function uses setTimeout to update classifications after render. If the store is destroyed before the timeout fires (e.g., during navigation), it could access dead nodes. Added isAlive(self) check at the start of the setTimeout callback to prevent accessing destroyed store state.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9263 +/- ##
===========================================
- Coverage 66.82% 57.66% -9.16%
===========================================
Files 830 561 -269
Lines 64879 40549 -24330
Branches 10971 11010 +39
===========================================
- Hits 43355 23383 -19972
+ Misses 21520 17162 -4358
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
setTimeoutinselectHistory()can fire after the store is destroyed (e.g., during navigation), causing it to access dead MST nodes and throw warnings.Solution
Add
isAlive(self)guard at the start of the setTimeout callback to prevent accessing destroyed store state.Files Changed
web/libs/editor/src/stores/Annotation/store.js