Skip to content

Feature/angular15#6

Merged
ramijebara merged 7 commits intoHyperviewHQ:masterfrom
pavandixit93:master
Feb 7, 2023
Merged

Feature/angular15#6
ramijebara merged 7 commits intoHyperviewHQ:masterfrom
pavandixit93:master

Conversation

@pavandixit93
Copy link

Angular migration:
cexbrayat/angular-cli-diff@14.2.0...15.1.4

LINTING:
angular2gridster-lint

FRONTEND CODE COVERAGE:
Tests configuration is broken in the main branch and also in this fork.
There are currently no test files in the entire project.

Builds successfully:
angular2gridster-build

Outputs correct assets to dist:
angular2gridster-assets-dist-output

Working demo:
angular2gridster-working-demo.webm

@pavandixit93
Copy link
Author

Hi @ramijebara
I have updated dependencies to Angular 15 by using -

  1. https://update.angular.io/?l=2&v=14.0-15.0
  2. cexbrayat/angular-cli-diff@14.2.0...15.1.4
    Please do the needful further review. This is my first time to contribute so kindly Let me know if I am missing any workflow here.

Thank you,

@pavandixit93 pavandixit93 mentioned this pull request Feb 3, 2023
@ramijebara
Copy link

Thank you @pavandixit93! I will review today.

Copy link

@ramijebara ramijebara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, Thank you!
I have added a couple of comments and suggestions for you. Please take a look and update the PR as needed.

@ramijebara
Copy link

@pavandixit93 Thank you! I noticed you made some changes in response to the comments. Please give me a chance to review and let you know.

@ramijebara
Copy link

@pavandixit93 I will accept and merge your PR. Thank you. Please note that after the PR is merged I will make some minor changes to remove code and config that is no longer relevant. Once done, I will push the new package to npm.

@ramijebara ramijebara merged commit e6851cf into HyperviewHQ:master Feb 7, 2023
@pavandixit93
Copy link
Author

@ramijebara Great, Thank you. Let me know once package is published, i will start using the same in my project. Thanks for your help.

@ramijebara
Copy link

@pavandixit93 the npm package was published earlier today. Thank you!

@pavandixit93
Copy link
Author

@ramijebara Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants