add saving and loading infairness component state to disk#57
Merged
MayankAgarwal merged 2 commits intomainfrom Sep 20, 2022
Merged
add saving and loading infairness component state to disk#57MayankAgarwal merged 2 commits intomainfrom
MayankAgarwal merged 2 commits intomainfrom
Conversation
moonfolk
approved these changes
Sep 20, 2022
moonfolk
left a comment
There was a problem hiding this comment.
Can we also add a way to access logistic regression coefficients (including bias - it is often useful to check LR accuracy when learning the fair metric) in this PR or do you want to do a different PR for it? I am suggesting it here since we also want to save it along with sigma probably?
Another comment, which could be a separate PR, we want to provide additional input arguments when fitting LR such as optimizing for balanced accuracy via class_weight='balanced'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #56
This PR adds support for saving and loading trained distance metrics to disk. The format is the same as PyTorch modules, like:
Refer: https://pytorch.org/tutorials/beginner/saving_loading_models.html#saving-loading-model-for-inference