Skip to content

admin: include ReplicaAssignment in ListTopics()#1274

Merged
varun06 merged 1 commit into
IBM:masterfrom
dnwe:include-replica-assignment-in-topicdetail
Feb 12, 2019
Merged

admin: include ReplicaAssignment in ListTopics()#1274
varun06 merged 1 commit into
IBM:masterfrom
dnwe:include-replica-assignment-in-topicdetail

Conversation

@dnwe

@dnwe dnwe commented Feb 8, 2019

Copy link
Copy Markdown
Collaborator

Follow-on from #1155 / #1178 include the replica assignment information that we got back in the ListTopics() TopicDetail responses

@varun06 varun06 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnwe

dnwe commented Feb 12, 2019

Copy link
Copy Markdown
Collaborator Author

@varun06 thanks for the approval, were you waiting for another reviewer before merge?

@varun06

varun06 commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

It is simple enough and I will merge it after another look today. In the mean time, if someone else want to review, that's great.

@varun06 varun06 merged commit ba151e1 into IBM:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants