Added test cases and a fix for Issue #409. #505
Merged
JarnoRFB merged 3 commits intoIDSIA:masterfrom Jul 10, 2019
Merged
Conversation
…ult with preset after setting in the conf
Collaborator
JarnoRFB
reviewed
Jul 10, 2019
tests/test_experiment.py
Outdated
|
|
||
|
|
||
| def test_add_config_dict_chain(ex): | ||
| # https://github.com/IDSIA/sacred/issues/409 |
Collaborator
There was a problem hiding this comment.
Suggested change
| # https://github.com/IDSIA/sacred/issues/409 |
I think we do not have to refer to solved issues in the code as the test now clearly documents the intended behavior.
Collaborator
|
@wecacuee looks great. Please just delete the one comment and then we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #409 : Recursively fill in the result with preset after setting in the conf in ConfigDict.call