-
Notifications
You must be signed in to change notification settings - Fork 391
S3 FileObserver #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
S3 FileObserver #542
Changes from 41 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
4c43dc8
Add implementation of directory saving
decodyng 4d18ad3
basic tests for s3 observer
decodyng 4524364
remove unused imports
decodyng 12bb9cc
fix format string
decodyng f687d9d
Add boto3 to requirements for testing purposes
decodyng bb3ecf5
fix flake8 issues and add moto for test mocking
decodyng b688cb6
hopefully fix issue with google compute engine
decodyng 5de6e42
give up and install google-compute-engine
decodyng 0027662
add default location
decodyng d1d7bae
add decode utf to enforce python 3.5 compatibility
decodyng 5b993c2
Clean up and add more tests
decodyng 5b44c48
fix format string
decodyng 25d26c9
flake8 fixes
decodyng 0c20f66
remove recursive artifacts
decodyng 883ced1
remove newline
decodyng a8c3f59
add more test coverage
decodyng 777a7f5
change observer name, refactor list_s3_subdirs to have an explicit bu…
decodyng a929db8
add ability to pass in region, and error on Observer creation if regi…
decodyng 9788e86
fix error handling
decodyng f4a0299
fix comment
decodyng c1f49b9
Merge branch 'master' into s3_observer
decodyng 3dd47bf
fix flake8 issues
decodyng bc5d296
explicitly set region in tests
decodyng ab5fafb
start to write s3observer docs
decodyng c86fe0c
Merge branch 's3_observer' of github.com:HumanCompatibleAI/sacred int…
decodyng fedf694
add requirement in tox file
decodyng 3889e33
black reformatting
decodyng ed58c96
pass in region for tests
decodyng d481d66
remove use of os.path.join to get around issues with windows paths
decodyng 3c2315c
more black reformatting
decodyng f418e34
remove comma because of python 3.5 syntax error
decodyng 553b195
fix black project toml, update s3_join method, fix tests to use s3_join
decodyng a6b3415
reformat for black modulo mongo comma issue
decodyng fb07ac2
fix s3_join calls to not pass in list
decodyng df571a4
changes to mongo
decodyng 3d1c48f
fix py35 issues
decodyng f5b10a4
sync py35 error cases with master
decodyng bcd1904
add new lines at end of files
decodyng e63720d
sync offending black files with master
decodyng d83a290
remove final newline
decodyng 558a79c
add end quotations to pyproject.toml
decodyng 6f99985
remove Z from test name
decodyng 365d2d1
fix string line breaks
decodyng 548d7c1
remove create method and update docs accordingly
decodyng 00d1f34
remove create method from s3 tests
decodyng 22ce54f
clean up docs
decodyng 3d52c2f
fix black issue in test_s3_observer, worried this will annoy flake8
decodyng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,5 @@ mock>=2.0.0 | |
| munch>=2.0.4 | ||
| pbr>=1.10.0 | ||
| wrapt>=1.10.8 | ||
| packaging>=18.0 | ||
| packaging>=18.0 | ||
| boto3>=1.9.0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please then also update the docs to use
__init__instead ofcreate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A slightly tangential question: I notice as I'm editing the docs that they don't seem to presently be up to date for the existing observers (i.e. the current master docs say "Sacred ships with four observers" and then has a list that doesn't include the Slack, Telegram, or Neptune observers. I feel slightly weird about continuing the error to say "Sacred ships with five observers", but also don't feel conversant enough about how the Slack/Telegram/Neptune observers work to add the summary documentation for them, so by default I'll just up the number to five and add the S3Observer to the list, but just flagging this as something I wanted to make sure was intentional on the part of the maintainers.