Preset distribution: do not duplicate ingredient path#777
Merged
thequilo merged 2 commits intoIDSIA:masterfrom Oct 30, 2020
Merged
Preset distribution: do not duplicate ingredient path#777thequilo merged 2 commits intoIDSIA:masterfrom
thequilo merged 2 commits intoIDSIA:masterfrom
Conversation
Contributor
Author
|
@thequilo for review |
thequilo
approved these changes
Oct 30, 2020
Collaborator
thequilo
left a comment
thequilo
left a comment
There was a problem hiding this comment.
Thank you! I think this bug slipped through in one of my previous PRs, so thanks for fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#769 had a typo that causes the scaffolding path to be concatenated twice. This PR fixes that typo and adds a test case for one instance which broke (passes in old Sacred, fails before this PR, passes after this PR).