Skip to content

Fix numpy deprecation warning#870

Merged
thequilo merged 1 commit intoIDSIA:masterfrom
Kaushalya:fix_np_deprecation
Jun 23, 2022
Merged

Fix numpy deprecation warning#870
thequilo merged 1 commit intoIDSIA:masterfrom
Kaushalya:fix_np_deprecation

Conversation

@Kaushalya
Copy link
Contributor

Fixes the issue #851 by removing np.int and np.float from custom_containers.py.

@thequilo
Copy link
Collaborator

Thank you @Kaushalya! Do you have an idea why the testcases fail? I believe this has nothing to do with your changes.

@Kaushalya
Copy link
Contributor Author

Kaushalya commented Jun 22, 2022

Thank you @Kaushalya! Do you have an idea why the testcases fail? I believe this has nothing to do with your changes.

No, that's a separate issue due to an older Black version in the pre-commit-config.yaml.

Traceback (most recent call last):
  File "/home/vsts/.cache/pre-commit/repoixwdm4yz/py_env-python3/bin/black", line 8, in <module>
    sys.exit(patched_main())
  File "/home/vsts/.cache/pre-commit/repoixwdm4yz/py_env-python3/lib/python3.9/site-packages/black/__init__.py", line 1423, in patched_main
    patch_click()
  File "/home/vsts/.cache/pre-commit/repoixwdm4yz/py_env-python3/lib/python3.9/site-packages/black/__init__.py", line 1409, in patch_click
    from click import _unicodefun
ImportError: cannot import name '_unicodefun' from 'click' (/home/vsts/.cache/pre-commit/repoixwdm4yz/py_env-python3/lib/python3.9/site-packages/click/__init__.py)

https://dev.azure.com/qwlouse/Sacred%20CI/_build/results?buildId=590&view=logs&j=ac34510b-08de-5f02-c447-c38b966a6e9d&t=fa1e8bef-4a59-5d1a-f160-778c58d5909c&l=107

@thequilo thequilo merged commit d6fedfb into IDSIA:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants