Fix exception causes in config_scope.py#894
Merged
thequilo merged 1 commit intoIDSIA:masterfrom Jan 19, 2023
Merged
Conversation
Collaborator
|
Thanks! Can you fix the tests? |
Collaborator
|
Nevermind, this doesn't seem to be caused by your changes |
Contributor
Author
|
Why would the tests need to be fixed?
…On Tue, Jan 10, 2023, 20:33 Thilo von Neumann ***@***.***> wrote:
Thanks! Can you fix the tests?
—
Reply to this email directly, view it on GitHub
<#894 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN3SXPENQMIGKQVHGG73LWRWTORANCNFSM6AAAAAATPAYN4I>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
|
They don't, the failing tests are not related to your changes. I just saw some failed checks and thought that the changed exception traceback broke some tests. Thanks for improving the error messages with this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More context for this change here: https://blog.ram.rachum.com/post/621791438475296768/improving-python-exception-chaining-with