Conversation
|
We could introduce notification handling for this case as well, but we wanted to keep this PR minimal, so it can be addressed in a follow-up PR. |
|
|
|
I'd suggest using ColorScheme.fromSeed to generate a color scheme from Please see:
|
|
@deminearchiver thank you for the suggestions! I have refined the UI to make it cleaner and less visually heavy |
|
@deminearchiver thanks a lot, this looks great! I'll apply the changes today. |
|
I've submitted a review suggesting design changes. Please review them, I can't promise everything still works since I did them in DartPad, but all should be fine. I recommend double-checking that all buttons still work as expected and there are no build errors. |
|
@deminearchiver sounds good, thanks! I’ll review the changes and double check everything. |
|
@deminearchiver Thank you for the suggestions. Nothing is broken and everything looks good. Before applying the changes, I wanted to check with @ImranR98 which version we want to go with. Current versionNew versionSuggested by @deminearchiver using custom design based on an expressive list from Material 3 Expressive. |
|
That's nice! I remembered that the horizontal margin must probably be 8 instead of 16. That's how it is in the official examples. Because 16 + 16 is too much and 8 + 16 is fine. |
|
Should we maybe modify it further to better match the initial Figma design?>#2742 (comment) |
I think it matches already, no? There are two things that can't be implemented without major theme changes:
The code I suggested implements the Figma design as closely as possible. |
|
@deminearchiver I was referring more to the colors. The Figma version has higher contrast and a stronger highlight, but I think your suggested version aligns better with the app theme. Let's wait for @ImranR98's opinion on #2742 (comment), then we'll proceed. |
The Figma version uses the new color generation spec which is supported in Android 16 when using dynamic color. |
|
I think the new version suggested by @deminearchiver looks nicer. It just sucks that we need so much custom UI code -- would be nice if Flutter just had M3E components already (apparently that's unlikely to happen until late this year at the earliest). |
I have a hard fork of Obtainium, called Materium. The aim is to integrate it with the new Material 3 Expressive update by building my own component library. I'm also looking to completely rewrite the actual logic behind the app, but the code is really big and messy (as I have mentioned in some other issue), so I'm not optimistic about doing it now. If you don't like the amount of code needed to create the design (it's not like I do either), I could make it less expressive and use default Flutter components to build something a bit more compact. |
|
Nah we can keep your version even if it's more verbose. |
|
Also unrelated to this issue, if you're going to rewrite much of the app, have you considered doing it in native Kotlin? (I regret not doing so tbh, but Flutter was just easier to learn and I already had some experience with it) |
Alright, but I had a thought that making a sudden Material 3 Expressive jumpscare in the app would scare off users.
I regret to inform you that I'm not a Kotlin developer 🤣. Placing all bets on Flutter because I love it. At this point, I'm basically doing what Flutter has yet to implement - a fully custom-made Material 3 Expressive design library. |
Co-authored-by: deminearchiver <83916788+deminearchiver@users.noreply.github.com>
Co-authored-by: deminearchiver <83916788+deminearchiver@users.noreply.github.com>
|
Thank you both for the help. |







Fixes #2637
Summary
Screenshots
Notes
Testing
This has only been tested locally using mocks and needs real testing before merging.