feat(paper): add a provided sender mapper#92
Merged
Conversation
modern paper manager requires the use of CommandSourceStack which doesn't have built in ways to require a Player or Console sender. this adds a built-in way for common behaviour.
masmc05
reviewed
Aug 3, 2024
cloud-paper/src/main/java/org/incendo/cloud/paper/sender/PlayerSource.java
Outdated
Show resolved
Hide resolved
jpenilla
force-pushed
the
feature/modern-paper-provided-sender
branch
from
ffeb7a5 to
75f14e2
Compare
jpenilla
approved these changes
Aug 3, 2024
Member
jpenilla
left a comment
jpenilla
left a comment
There was a problem hiding this comment.
Needs something on the docs site, also someone else should go over the Javadoc once more.
Citymonstret
approved these changes
Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not a big fan of the names currently, maybe #source instead of #sender?