Fix double legend in grouped_ggbarstats and grouped_ggpiestats

.gitignore

@@ -56,6 +56,8 @@ Temporary Items
 .claude
 .claude/settings.local.json
 .httr-oauth
+.vscode
+Rplots.pdf
 /Meta/
 /doc/
 CRAN-SUBMISSION

R/ggbarstats.R

@@ -136,14 +136,16 @@ ggbarstats <- function(
     ) +
     exec(
       geom_label,
-      mapping  = aes(label = .label, group = {{ x }}),
-      position = position_fill(vjust = 0.5),
+      mapping     = aes(label = .label, group = {{ x }}),
+      position    = position_fill(vjust = 0.5),
+      show.legend = FALSE,
+      na.rm       = TRUE,
       !!!label.args
     ) +
     ggtheme +
     theme(panel.grid.major.x = element_blank()) +
     guides(fill = guide_legend(title = legend.title %||% as_name(x))) +
-    paletteer::scale_fill_paletteer_d(paste0(package, "::", palette), name = "")
+    paletteer::scale_fill_paletteer_d(paste0(package, "::", palette), name = "", drop = FALSE)
 
   # proportion test ------------------------------------------
 

R/ggpiestats-ggbarstats-helpers.R

@@ -9,17 +9,34 @@ descriptive_data <- function(
   digits.perc = 1L,
   ...
 ) {
-  .cat_counter(data, {{ x }}, {{ y }}) %>%
+  # retain all original factor levels so grouped plots share a single legend;
+  # without this, patchwork::guides("collect") can't merge legends across
+
+  # grouped sub-plots when groups have different observed levels (#868)
+  all_lvls <- levels(dplyr::pull(data, {{ x }}))
+
+  result <- .cat_counter(data, {{ x }}, {{ y }}) %>%
     mutate(
       .label = if (grepl("perc|prop", label.content)) {
         paste0(round(perc, digits.perc), "%")
       } else if (grepl("count|n|N", label.content)) {
         .prettyNum(counts)
       } else {
         paste0(.prettyNum(counts), "\n", "(", round(perc, digits.perc), "%)")
-      }, # reorder the category factor levels to order the legend
-      {{ x }} := factor({{ x }}, unique({{ x }}))
+      },
+      {{ x }} := factor({{ x }}, union(rev(all_lvls), unique({{ x }})))
     )
+
+  # Inject zero-count rows for unobserved factor levels so that every layer
+  # (geom_bar / geom_col) can draw a proper legend key glyph for every level.
+  # Without this, patchwork sees structurally different guide grobs and
+  # refuses to collect them into a single shared legend (#868).
+  result <- tidyr::complete(
+    result, {{ x }}, {{ y }},
+    fill = list(counts = 0L, perc = 0, .label = NA_character_)
+  )
+
+  result
 }
 
 

R/ggpiestats.R

@@ -181,6 +181,8 @@ ggpiestats <- function(
         min.segment.length = 0,
         fill               = "white",
         alpha              = 1.0,
+        show.legend        = FALSE,
+        na.rm              = TRUE,
         !!!label.args
       )
   }))
@@ -192,7 +194,7 @@ ggpiestats <- function(
   plotPie <- plotPie +
     coord_polar(theta = "y") +
     scale_y_continuous(breaks = NULL) +
-    paletteer::scale_fill_paletteer_d(paste0(package, "::", palette), name = "") +
+    paletteer::scale_fill_paletteer_d(paste0(package, "::", palette), name = "", drop = FALSE) +
     ggtheme +
     theme(panel.grid = element_blank(), axis.ticks = element_blank()) +
     guides(fill = guide_legend(override.aes = list(color = NA)))