Implement dpctl.tensor.isdtype #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
||
| @pytest.mark.parametrize("dtype_str", list_dtypes) | ||
| def test_isdtype_kind_tuple(dtype_str): | ||
| if dtype_str.startswith("bool"): |
Contributor
There was a problem hiding this comment.
Similar here, save dpt.dtype(dtype_str) and reuse it.
oleksandr-pavlyk
approved these changes
Mar 22, 2023
Contributor
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
This looks good to me! Thank you @vlad-perevezentsev
|
Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_18 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
dpctl.tensor.isdtypefunction according to Python array API standard .This function takes a data type object and either a data type object, a string with the name of the kind of type(e.g. 'bool', 'real floating', 'numeric') or a tuple of strings or data types, and returns a boolean value indicating whether the input
dtypeis of a specified or is equal to the specified data type.The PR solves #1119