Skip to content

Implements negative, positive, pow, and square #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndgrigorian merged 4 commits into from
Jul 4, 2023
Merged

Implements negative, positive, pow, and square #1268

ndgrigorian merged 4 commits into from
Jul 4, 2023

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jun 29, 2023 •
edited
Loading

This pull request implements elementwise functions dpctl.tensor.negative, dpctl.tensor.positive, dpctl.tensor.pow, and dpctl.tensor.square.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian force-pushed the more-elementwise-functions branch from dffadfd to 44d5df2 Compare June 29, 2023 08:43
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1268/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jun 29, 2023 •
edited
Loading

Coverage Status

coverage: 83.282% (+0.01%) from 83.271% when pulling 4748233 on more-elementwise-functions into 7bfc5a0 on master.

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_5 ran successfully.
Passed: 420
Failed: 580
Skipped: 119

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_5 ran successfully.
Passed: 421
Failed: 579
Skipped: 119

@ndgrigorian ndgrigorian force-pushed the more-elementwise-functions branch from 44d5df2 to 70b56e3 Compare July 4, 2023 09:08
@ndgrigorian ndgrigorian changed the title Implements hypot, negative, positive, pow, and square Implements negative, positive, pow, and square Jul 4, 2023
@ndgrigorian ndgrigorian force-pushed the more-elementwise-functions branch from 70b56e3 to 55caa04 Compare July 4, 2023 09:17
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_10 ran successfully.
Passed: 431
Failed: 569
Skipped: 119

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_10 ran successfully.
Passed: 431
Failed: 569
Skipped: 119

@ndgrigorian
pow no longer uses std::pow for integers
602eef1 
- Not portable to devices without 64-bit precision
@ndgrigorian ndgrigorian marked this pull request as ready for review July 4, 2023 10:49
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_11 ran successfully.
Passed: 433
Failed: 567
Skipped: 119

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_12 ran successfully.
Passed: 432
Failed: 568
Skipped: 119

@vlad-perevezentsev vlad-perevezentsev self-requested a review July 4, 2023 16:19
vlad-perevezentsev
vlad-perevezentsev approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks @ndgrigorian

@ndgrigorian ndgrigorian merged commit 7510d7e into master Jul 4, 2023
@ndgrigorian ndgrigorian deleted the more-elementwise-functions branch July 4, 2023 17:06
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_12 ran successfully.
Passed: 432
Failed: 568
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ndgrigorian @coveralls @vlad-perevezentsev @antonwolfy