Skip to content

Conversation

@oleksandr-pavlyk
Copy link
Contributor

Changed signatures functions to take sycl::queue argument by reference, not by value.

Since sycl::queue contains a shared pointer inside, copying it involves operating atomic variable, and hence should be avoided if possible.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Apr 18, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_296 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 88.049%. remained the same
when pulling ffe13ea on change-signatures-to-use-queue-ref
into 182aede on master.

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit a8acdf0 into master Apr 18, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the change-signatures-to-use-queue-ref branch April 18, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants