Skip to content

Conversation

@ndgrigorian
Copy link
Collaborator

This pull request proposes removal of PythonObjectUnboxer in favor of a pybind11 type caster for sycl::half. This permits extensions to convert Python scalars to sycl::half with only the inclusion of dpctl4pybind11.hpp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

`py::cast<sycl_half>` being available makes PythonObjectUnboxer redundant
@github-actions
Copy link

github-actions bot commented Apr 25, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Apr 25, 2024

Coverage Status

coverage: 88.218%. remained the same
when pulling 3f1a40d on type-caster-sycl-half
into aaf444e on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_312 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_313 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_314 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

@ndgrigorian ndgrigorian merged commit b12583a into master Apr 27, 2024
@ndgrigorian ndgrigorian deleted the type-caster-sycl-half branch April 27, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants