Skip to content

Added support for consuming DLPack allocated on a sub-device #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oleksandr-pavlyk merged 3 commits into from
Nov 9, 2022
Merged

Added support for consuming DLPack allocated on a sub-device #984

oleksandr-pavlyk merged 3 commits into from
Nov 9, 2022

Conversation

@oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Nov 9, 2022 •
edited
Loading

USM allocation must be bound to the default context. When producing DLPack, 'device_id; is populated with id of the ancestor root device.

  • Have you provided a meaningful PR description?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/984/index.html

@coveralls
Copy link
Collaborator

coveralls commented Nov 9, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 81.938% when pulling 7bd938d on extend-dlpack-for-update-in-compiler into c1335f1 on master.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_64 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the extend-dlpack-for-update-in-compiler branch from 0fa30ee to 70fdc5e Compare November 9, 2022 00:57
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_64 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the extend-dlpack-for-update-in-compiler branch from 91a2851 to 72386fe Compare November 9, 2022 01:54
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_68 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_68 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_69 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev2=py310h8c27c75_6 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk
Added support for consuming DLPack allocated on a sub-device
1af5e56 
USM allocation must be bound to the default context. When producing
DLPack, device_id is populated with id of the ancestor root device.

Code remains functional on systems where default_context extension
support is not enabled (e.g. Windows), but DLPack sharing is limited
to allocation made on root devices only.
@oleksandr-pavlyk
Raise RuntimeError is default_context underlying library called fault…
72164a0 
…ered
@oleksandr-pavlyk
Added entry to changelog for changes in this PR
7bd938d
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the extend-dlpack-for-update-in-compiler branch from e8c29dd to 7bd938d Compare November 9, 2022 19:34
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev2=py310h8c27c75_4 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit 530a7d7 into master Nov 9, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the extend-dlpack-for-update-in-compiler branch November 9, 2022 21:18
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev2=py310h8c27c75_4 ran successfully.
Passed: 32
Failed: 802
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oleksandr-pavlyk @coveralls