Skip to content

Add sycl device sub group sizes property #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oleksandr-pavlyk merged 4 commits into from
Nov 9, 2022
Merged

Add sycl device sub group sizes property #985

oleksandr-pavlyk merged 4 commits into from
Nov 9, 2022

Conversation

@oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Nov 9, 2022

This PR implements dpctl.SyclDevice.sub_group_sizes property as requested in #975

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/985/index.html

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev2=py310h8c27c75_4 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@coveralls
Copy link
Collaborator

coveralls commented Nov 9, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 82.064% when pulling b7028f3 on add-SyclDevice-sub-group-sizes-property into c1335f1 on master.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev2=py310h8c27c75_5 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-SyclDevice-sub-group-sizes-property branch from 6aaa41f to b7028f3 Compare November 9, 2022 19:48
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev2=py310h8c27c75_4 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk
Added size_t *DPCTLDevice_GetSubGroupSizes(DRef, size_t res_len)
b88bd7a 
The function exposes `device::get_info<info::device::sub_group_sizes>()`
which returns `std::vector<size_t>`.

DPCTLDevice_GetSubGroupSizes returns pointer to allocated array, populated
with the content of the result std::vector. res_len is set with the size
of the result std::vector.
@oleksandr-pavlyk
Exposed dpctl.SyclDevice.sub_group_sizes property
298dd86 
The property returns a vector of supported sub-group sizes.

The relationship to `SyclDevice.max_num_sub_groups` is not
clear at the moment.
@oleksandr-pavlyk
Extended examples/pybind11/use_dpctl_syclqueue/use_queue_device
d1bb117 
Added a function that retrieves sub_group_sizes property of the device.
@oleksandr-pavlyk
Added entry about this PR to change-log
99f8a91
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the add-SyclDevice-sub-group-sizes-property branch from b7028f3 to 99f8a91 Compare November 9, 2022 21:21
@oleksandr-pavlyk oleksandr-pavlyk merged commit fa8eb17 into master Nov 9, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-SyclDevice-sub-group-sizes-property branch November 9, 2022 21:21
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev2=py310h8c27c75_9 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Array API standard conformance tests for dpctl=0.14.0dev2=py310h8c27c75_9 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@ogrisel
Copy link

ogrisel commented Nov 14, 2022

Thanks @oleksandr-pavlyk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-pavlyk @coveralls @ogrisel