Skip to content

Support ghc 9.14#5292

Merged
lehins merged 4 commits intomasterfrom
erikd/ghc-9.14
Feb 25, 2026
Merged

Support ghc 9.14#5292
lehins merged 4 commits intomasterfrom
erikd/ghc-9.14

Conversation

@erikd
Copy link
Contributor

@erikd erikd commented Sep 16, 2025

Description

Preliminary ghc 9.14 support

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@erikd erikd requested a review from a team as a code owner September 16, 2025 04:19
@erikd
Copy link
Contributor Author

erikd commented Sep 16, 2025

I ran scripts/fourmolize.sh and it changed the formating of a bunch of stuff that I had not touched and seemingly does not handle the CPP I needed to get this compiling.

I ran scripts/gen-hie.sh but all it did was delete the entire contents of the hie.yaml file.

@erikd erikd marked this pull request as draft September 16, 2025 10:55
@erikd erikd force-pushed the erikd/ghc-9.14 branch 4 times, most recently from 4caf7a2 to 2f9f42c Compare September 17, 2025 02:37
@erikd erikd force-pushed the erikd/ghc-9.14 branch 4 times, most recently from 72fb4af to 9597702 Compare October 22, 2025 00:59
@erikd erikd force-pushed the erikd/ghc-9.14 branch 3 times, most recently from 81d27c3 to ff460d5 Compare October 31, 2025 09:19
@erikd erikd force-pushed the erikd/ghc-9.14 branch 4 times, most recently from d186d46 to e59ead7 Compare November 10, 2025 02:27
@erikd erikd force-pushed the erikd/ghc-9.14 branch 3 times, most recently from 5333ff1 to f3525d7 Compare November 16, 2025 22:05
@erikd erikd force-pushed the erikd/ghc-9.14 branch 2 times, most recently from 57e001b to dfdf088 Compare November 25, 2025 04:22
@erikd erikd force-pushed the erikd/ghc-9.14 branch 2 times, most recently from 908f4fb to fe69daf Compare December 4, 2025 00:19
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the PR and got really scared by all CPP in it.
We ought to resort to CPP only when we absolutely have to. In this case it doesn't look like it is the case, hence I left a couple of comments with suggestions on how we can get rid of them.

@erikd erikd force-pushed the erikd/ghc-9.14 branch 2 times, most recently from 2c5ec68 to e8a1606 Compare December 10, 2025 21:26
@erikd erikd force-pushed the erikd/ghc-9.14 branch 2 times, most recently from 1e1800a to b932284 Compare January 22, 2026 23:32
@erikd erikd force-pushed the erikd/ghc-9.14 branch 7 times, most recently from 58775ab to 9024a1f Compare February 23, 2026 08:19
@erikd erikd marked this pull request as ready for review February 23, 2026 08:47
@erikd erikd changed the title WIP: Preliminary ghc 9.14 support Support ghc 9.14 Feb 23, 2026
@erikd erikd force-pushed the erikd/ghc-9.14 branch 2 times, most recently from eae6454 to ece662c Compare February 23, 2026 13:08
@erikd erikd enabled auto-merge February 24, 2026 09:19
@erikd erikd force-pushed the erikd/ghc-9.14 branch 2 times, most recently from 5b0d46d to e0fa45d Compare February 25, 2026 00:04
@erikd erikd disabled auto-merge February 25, 2026 04:47
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lehins lehins merged commit 532def7 into master Feb 25, 2026
240 of 242 checks passed
@lehins lehins deleted the erikd/ghc-9.14 branch February 25, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants