Merged
Conversation
Closed
There was a problem hiding this comment.
Pull request overview
This PR updates DMQ node documentation and build/dependency tooling, adds a GitHub Pages workflow for publishing Haddocks, and adjusts runtime/configuration defaults/behavior to better match current project expectations.
Changes:
- Add CLI help defaults and update the default config filename to
dmq.config.json. - Add a scheduled GitHub Pages workflow to build and publish Haddocks.
- Update dependency pins (CHaP / cabal.project / flake.lock) and switch ouroboros-network dependency source/versioning.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
flake.lock |
Updates CHaP pin (narHash/rev/lastModified). |
dmq-node/src/DMQ/Configuration/CLIOptions.hs |
Adds displayed defaults to CLI options (currently affects precedence/overrides). |
dmq-node/src/DMQ/Configuration.hs |
Changes default config filename and tweaks error string. |
dmq-node/dmq-node.cabal |
Updates ouroboros-network constraint and adds directory dependency for executable. |
dmq-node/app/Main.hs |
Adds socket-path existence check and adjusts program description/imports. |
cabal.project |
Bumps index-state and updates source-repository-package pins/removals. |
README.md |
Expands run/config docs and adds examples (with some command formatting/typos). |
.github/workflows/github-page.yml |
New workflow to build Haddocks and deploy to GitHub Pages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
4 tasks
coot
force-pushed
the
coot/documentation
branch
3 times, most recently
from
214a7ad to
b112951
Compare
* Included basic run instructions. * Added build docker image instructions.
coot
force-pushed
the
coot/documentation
branch
from
b112951 to
3dbb4c2
Compare
coot
force-pushed
the
coot/documentation
branch
from
3dbb4c2 to
94407a6
Compare
coot
force-pushed
the
coot/documentation
branch
2 times, most recently
from
2470512 to
4e307f5
Compare
* ouroboros-network * cardano-ledger
We cannot use `value <> showDefault`, since then the CLI will always overwrite configuration option, so we show default with a custom helper function.
GHC-9.12.2 suffers from a compiler bug which prevents building haddocks https://gitlab.haskell.org/ghc/ghc/-/issues/25739
coot
force-pushed
the
coot/documentation
branch
from
4e307f5 to
e227ad2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist