Expose min utilization for autoalloc#927
Merged
Kobzol merged 1 commit intoIt4innovations:mainfrom Jun 13, 2025
Merged
Conversation
Kobzol
force-pushed
the
autoalloc-min-utilization
branch
from
ee1b82f to
3b8043f
Compare
Collaborator
|
Can we have an end-to-end test that checks that the functionality is working? I made some tests but only on the scheduler level. |
Member
Author
|
I thought about it, but I think that I first need to implement proper resources for queues. Now I tell the scheduler that every queue has 1 CPU core and nothing else. Not sure if min utilization will work with that? 😆 |
Collaborator
|
Good point. Btw: The fact that it says that it has 1 cpus will cause the problem: if all tasks needs >1cpu or some other resource then autoalloc will never allocate. So it is not compatible with the previous version in this respect. |
spirali
approved these changes
Jun 13, 2025
Member
Author
|
Yeah, it's definitely something we need to resolve before publishing a next release. But the previous PR was already quite big, so I'll do it in a follow-up next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #886