New page and some minor fixes#62
Open
rjplevin wants to merge 1 commit intoJGCRI:gh-pagesfrom
rjplevin:gh-pages
Open
New page and some minor fixes#62rjplevin wants to merge 1 commit intoJGCRI:gh-pagesfrom rjplevin:gh-pages
rjplevin wants to merge 1 commit intoJGCRI:gh-pagesfrom
rjplevin:gh-pages
Conversation
…es in Visual Studio Code.app (with default black background) suggested this was necessary. - Added page 'gcam-xml.md' to explain how basic XML processing works in GCAM. - Fixed a couple of XML elements that needed to be backquoted (policies.md)
pralitp
requested changes
Jan 29, 2019
Contributor
pralitp
left a comment
pralitp
left a comment
There was a problem hiding this comment.
Thanks Rich. These changes look good. I want to add some details and clarifications to the XML page but I think I will just do that as a separate PR.
|
|
||
| To reduce redundancy, most technologies are defined in an element in the XML files called the `global-technology-database`, which we'll abbreviate here as GTDB. This provides common information about technologies, and of which can be overwritten in individual regions. Regional references to technologies in the GTDB are specified using the `stub-technology` element. | ||
|
|
||
| The `global-technology-database` element occurs in 54 files in GCAM v5.1.2. As the XML files are read in, these elements are merged according to the rules above. After all of the XML files have been |
Contributor
There was a problem hiding this comment.
Let's drop the specific numbers here with the reference to the GCAM version. We are trying to avoid having too many places with specifics like this that we would then have to go back and update when things change.
Author
There was a problem hiding this comment.
If you're adding details etc, I assume you can delete the numbers, too, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added lightgray background color on some images. Previewing the files in Visual Studio Code.app (with default black background) suggested this was necessary since black text was illegible.
Added page 'gcam-xml.md' to explain how basic XML processing works in GCAM. [This obviously should be validated by Pralit or others]
Fixed a couple of XML elements that needed to be backquoted (policies.md)