Skip to content

test(web): cover Squadron selection after draft auto-balancing #139

Closed as not planned

Description

@Jacksondr5

Add focused regression coverage for choosing a Squadron after an unscoped draft has already been auto-balanced. Fable's milestone 5B re-review found that explicit Squadron retargeting retains the upstream store's environmentSelection: "auto" and previous loadBalancedEnvironmentId. Current behavior is correct: the selected-Squadron guard excludes balancing, and the selector label derives from that guard. No production fix or extra store flag is requested.

Exercise two environments for one logical project: auto-balance the unscoped draft, choose a Squadron on the other environment through the existing chip, and verify its project, carrier, prompt and model survive subsequent balance results/rerenders without moving again. Include automatic and manual environment controls refusing to change that selected owner, while explicit Squadron retarget remains available. This should test observable behavior, not merely assert persisted fields or callback wiring.

Relevant code: apps/web/src/components/ChatView.tsx, ChatView.logic.ts, and apps/web/src/j5/squadron/retargetSquadronDraft.ts. Existing policy and store tests passed independently; this extra transition case was non-blocking for the upstream integration's hands-on checkpoint. Avoid introducing a second ownership mechanism or a new balancing policy to make the test easier.

Activity

  1. Jacksondr5 commented on Oct 8, 2026

    @Jacksondr5
    OwnerAuthor

    Closing: Squadrons are retired and their behaviour is folded into projects (#412; merged in #454, #455, #456, #457, #482, #483, #484 and #489). A thread's home is now its project, so the Squadron this issue is about no longer exists. If part of this still applies to projects, reopen it or file it in those terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions