Skip to content

feat(server): Add built-in agent persona catalog - #76

Merged
Jacksondr5 merged 2 commits into
feature/agent-persona-definition-contractfrom
feature/agent-persona-catalog
Sep 14, 2026
Merged

Jacksondr5 merged 2 commits into
feature/agent-persona-definition-contractfrom
feature/agent-persona-catalog

Conversation

@bryantderosier

@bryantderosier bryantderosier commented Sep 3, 2026 •

Copy link
Copy Markdown
Collaborator

What does this implement or fix?

Adds the typed built-in persona identifiers, artifact and authority contracts, the server-owned eleven-persona catalog, deterministic lookup helpers, and focused catalog validation.

This is PR 2 of 10 in GitHub stack pingdotgg#120. It targets feature/agent-persona-definition-contract and depends on #75.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (clean-up or code structure improvement without changing behavior)
  • Documentation update

How has this been tested?

vp test run apps/server/src/j5/agents/agentPersonas.test.ts packages/contracts/src/orchestrationV2.test.ts — 24 tests passed.

The combined local integration suite also passed 350 tests across 17 files, scoped typechecks for server, web, mobile, contracts, and client runtime, and lint for 54 changed TypeScript files.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Screenshots or GIFs (Optional)

Not applicable.

Merge order

This PR is part of GitHub stack pingdotgg#120. Merge from bottom to top:

#75 -> #76 -> #78 -> #79 -> #80 -> #81 -> #83 -> #82 -> #85 -> #118

Stack rebuilt 2026-09-09 (stack pingdotgg#120): #84 and #86 were dropped, and fork-boundary refactors moved the persona RPCs, guards, and client wiring into J5-owned files. Review threads were preserved.

Generated with GPT-5 using the Codex desktop app.

@bryantderosier bryantderosier self-assigned this Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0c69586b-ed1a-4563-8942-2a08d260bd15

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Sep 3, 2026
@bryantderosier bryantderosier changed the title feat(server): DIGENG-0000 - Add built-in agent persona catalog feat(server): Add built-in agent persona catalog Sep 3, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog branch from 039290c to 15f7ce3 Compare September 3, 2026 16:18
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog branch from 15f7ce3 to 197860a Compare September 8, 2026 14:32
@github-actions github-actions Bot added size:XL 500-999 effective changed lines (test files excluded in mixed PRs). and removed size:L 100-499 effective changed lines (test files excluded in mixed PRs). labels Sep 8, 2026
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog branch from 197860a to 9f54dce Compare September 8, 2026 14:53
@github-actions github-actions Bot added size:L 100-499 effective changed lines (test files excluded in mixed PRs). and removed size:XL 500-999 effective changed lines (test files excluded in mixed PRs). labels Sep 8, 2026
@bryantderosier
bryantderosier removed this pull request from stack #89 September 9, 2026 13:01
bryantderosier and others added 2 commits September 14, 2026 08:05
Upstream orchestration structs keep only additive-optional references to the
assignment and request schemas; the persona vocabulary, availability, and
catalog schemas now live in packages/contracts/src/j5/agentPersona.ts and
reach consumers through one appended barrel export.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@bryantderosier
bryantderosier force-pushed the feature/agent-persona-catalog branch from 4ef3bf2 to 3fba3b1 Compare September 14, 2026 12:07
@Jacksondr5
Jacksondr5 merged commit a7bdc78 into j5/main Sep 14, 2026
20 checks passed
@Jacksondr5
Jacksondr5 deleted the feature/agent-persona-catalog branch September 14, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants