Repository navigation
docs(j5): a Mobile section in j5-live-test, and test-t3-mobile points at it - #838
Jacksondr5 wants to merge 2 commits into
Conversation
… at it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 35 minutes for your next included review. View limit details
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined review from both reviewers (Claude Opus 5.5 and GPT Sol 6.1), at 0ecb6960f9. We read the skill text against the merged rig code and found it accurate:
- the claim and cap refusals;
- the emulator's "still booting, run again";
- opening by the
emulator-<port>serial; mobile-build: commit first, one iOS build at a time;- the offline message;
- the new row in the setup table.
A cold agent can follow the Mobile section. Case 97 is free on trunk, and its file-table row mirrors case 68.
One fix (P3, accuracy). FORK.md case 97 says "teardown is device_close, then its stop". The PR's own skill text now closes the AgentDevice session first (j5-live-test step 5, and test-t3-mobile's teardown: "In J5, close the AgentDevice session first"). Case 97 should give the same order: AgentDevice close, then device_close, then stop. Otherwise whoever carries it through an upstream advance gets the old order.
Optional nits:
- Upstream line in "Open the device". In test-t3-mobile, the J5 sentence is joined onto upstream's
Call device_list, then device_open …line, which rewraps it. Putting the J5 sentence on its own lines leaves that upstream line byte-identical, so upstream syncs are a little cleaner. - Cache miss wording. "a native dependency changed" isn't the only cause of a missing dev client. A fresh host or a pruned cache misses too. The prescribed action (
mobile-build) is right either way.
This is agent-direction text, so Jackson reads it before merge.
…pstream's line stays intact Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined re-review from both reviewers (Claude Opus 5.5 and GPT Sol 6.1), at 065caf7316: resolved, no remaining findings.
- Case 97 now gives the skill's teardown order: AgentDevice close, then
device_close, thenstop. - test-t3-mobile, "Open the device". Upstream's
Call device_list…line is byte-identical to trunk again; the J5 sentence is its own paragraph. - Cache miss. The line now also covers a host that hasn't built the dev client yet.
Ready for Jackson to read as agent-direction text.
Problem
The mobile rig is on trunk:
--mobile ios|android,mobile-open,stop(#825) andmobile-build(#827). An agent only uses what a skill tells it to, though.j5-live-testhad nothing on mobile, and upstream'stest-t3-mobilestill said to runvp run devand pair throughpair-client.sh, which in J5 leaves the app empty. This is item W5 of the Mobile catch-up milestone.What changed
j5-live-testgets a "Mobile" section: the five steps (setup,device_open,mobile-open, drive, teardown), a row in "Other setups", and the points that tripped testers up in live runs:device_openonly after setup has printed the device;agent-device closebeforedevice_closeandstop, since a session left open holds the device against the next tester;mobile-buildwhen the client isn't cached;device_open, and the Android and iOS input quirks.test-t3-mobile(upstream's) is edited in place, keeping its structure. Each section gains a J5 pointer: set up with--mobile, launch and pair withmobile-open, and don't usepair-client.shin J5. Teardown is the AgentDevice close, thendevice_closeandstop. This mirrors what case 68 did fortest-t3-app, and is recorded as FORK.md case 97 with a file-table row.Live testing
Each line of the Mobile section comes from a live run.
test-reports/j5code-mobile-test-rig-skills/(aea0a411ee,18e8929839,5fcbc41744,2507fa4e7a,8cefc67d47).device_opentiming, theagent-device closeteardown, the Xcode component, and the one-tester limit.Nothing here changes runtime behaviour.
Upstream impact
.agents/skills/test-t3-mobile/SKILL.md: recorded as FORK.md case 97, with a file-table row in this PR. It is an edit in place, mirroring case 68.Checklist
FORK.md(case text and file-table row) in this PRBuilt by Claude Opus 5.5 in Claude Code (J5 Code crew seat).
🤖 Generated with Claude Code