Repository navigation
fix(j5): a mobile start refuses before building, and ends on the Mobile block - #862
Merged
Merged
Conversation
…le block A cold start found that a refused mobile start (iOS without a host, a missing config file) built the test home first, and that the Mobile block was lost at the end of the browser setup's output, beside a pairing link the device does not use. A mobile start now checks the settings and the host before building, and prints a short server summary with the browser marked optional, then the Mobile block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 37 minutes for your next included review. View limit details
|
Jacksondr5
commented
Nov 1, 2026
Jacksondr5
left a comment
Owner
Author
There was a problem hiding this comment.
Combined review from both reviewers (Claude Opus 5.5 and GPT Sol 6.1), at 3be7762e9e: no findings.
- Preflight before the home is built.
checkMobileCanStartruns instart()beforebuildHome. It covers the config, the iOS host (a recordediosHostis kept), the Android SDK, ABI and KVM, and the phone address. An actual CLI run with a named config file that doesn't exist exits 1 before "Building the test repository" and leaves no live-test home. - Server summary.
formatMobileServerreplacesprintRunningon both the device and phone paths. The fields are real manifest and path fields, and the browser pointer is accurate, becausestatusstill prints the browser's pairing link. A mobile start no longer mints a pairing link nobody uses. - Tests: the focused mobile and setup files pass, 108 tests.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A cold-start check of the mobile rig (artifact
mobile-catchup/coldstart-check.md) found two output problems:J5_MOBILE_RIG_CONFIGnaming a missing file) first spent 30 seconds building the test home, and left it behind.portsrange, which left the tester unsure which port the device uses.What changed
checkMobileCanStartruns before the home is built. It checks the settings, the iOS host (unless a setup is already recorded), the Android SDK, ABI and KVM, or the phone's address.statusfor a pairing link.Live testing
Builder, on openclaw, with an empty
XDG_CONFIG_HOMEso the defaults applied:--mobile ioswas refused with "No iOS host is set up…". There was no "Building…" line, and no.j5code/live-testwas left behind.--mobile androidprinted the short server summary with "Browser: optional", then the Mobile block (slot 1,emulator-5556, backend and Metro on 21444/21445) and its Next steps, ending the output.stopwas clean.Checklist
Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat).
🤖 Generated with Claude Code