Skip to content

fix(j5): a mobile start refuses before building, and ends on the Mobile block - #862

Merged
Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/mobile-start-output
Nov 1, 2026
Merged

Jacksondr5 merged 1 commit into
j5/mainfrom
j5code/mobile-start-output

Conversation

@Jacksondr5

Copy link
Copy Markdown
Owner

Problem

A cold-start check of the mobile rig (artifact mobile-catchup/coldstart-check.md) found two output problems:

  • A mobile start that can't run (iOS with no host configured, or a J5_MOBILE_RIG_CONFIG naming a missing file) first spent 30 seconds building the test home, and left it behind.
  • In a mobile run, the Mobile block came at the very end of about 40 lines written for browser testing. Those lines included a pairing link and a web port the device never uses, and the web port sits outside the configured ports range, which left the tester unsure which port the device uses.

What changed

  • Refuse before building. checkMobileCanStart runs before the home is built. It checks the settings, the iOS host (unless a setup is already recorded), the Android SDK, ABI and KVM, or the phone's address.
  • A shorter server summary in mobile mode. Mobile mode prints a short summary (home, log, owner, project, default model) instead of the browser instructions, followed by the Mobile block. The web server stays up, labelled "Browser: optional", with a pointer to status for a pairing link.
  • Why the web port isn't in the range. The dev runner derives it per worktree, and only a browser uses it. The device reaches the backend and Metro on the configured ports, shown in the Mobile block.

Live testing

Builder, on openclaw, with an empty XDG_CONFIG_HOME so the defaults applied:

  • Refused before building: --mobile ios was refused with "No iOS host is set up…". There was no "Building…" line, and no .j5code/live-test was left behind.
  • Output layout: --mobile android printed the short server summary with "Browser: optional", then the Mobile block (slot 1, emulator-5556, backend and Metro on 21444/21445) and its Next steps, ending the output.
  • Teardown: stop was clean.

Checklist

  • One concern: the description has no "also"
  • Tests cover the changed behavior: not added. This is an ordering change and output wording, verified live above. The checks it calls already have tests.
  • UI changes: none
  • Live testing: the section above
  • Upstream-owned files: none
  • Upstream product: no change
  • Surfaces: the test rig's mobile start
  • Docs: docs(j5): a Mobile section in j5-live-test for any machine #858 already says the Mobile block is the last part of the output

Built by Claude Opus 5.5 in Claude Code (J5 Code crew seat).

🤖 Generated with Claude Code

…le block

A cold start found that a refused mobile start (iOS without a host, a
missing config file) built the test home first, and that the Mobile block was
lost at the end of the browser setup's output, beside a pairing link the
device does not use. A mobile start now checks the settings and the host
before building, and prints a short server summary with the browser marked
optional, then the Mobile block.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
j5-code Ready Ready Preview Nov 1, 2026 2:27am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 37 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 54 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 68a9f69 and 3be7762.

Files selected for processing: 2
  • scripts/j5/live-test-mobile.ts
  • scripts/j5/setup-agent-live-test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Nov 1, 2026

@Jacksondr5 Jacksondr5 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combined review from both reviewers (Claude Opus 5.5 and GPT Sol 6.1), at 3be7762e9e: no findings.

  • Preflight before the home is built. checkMobileCanStart runs in start() before buildHome. It covers the config, the iOS host (a recorded iosHost is kept), the Android SDK, ABI and KVM, and the phone address. An actual CLI run with a named config file that doesn't exist exits 1 before "Building the test repository" and leaves no live-test home.
  • Server summary. formatMobileServer replaces printRunning on both the device and phone paths. The fields are real manifest and path fields, and the browser pointer is accurate, because status still prints the browser's pairing link. A mobile start no longer mints a pairing link nobody uses.
  • Tests: the focused mobile and setup files pass, 108 tests.

@github-actions github-actions Bot added the size:M 30-99 effective changed lines (test files excluded in mixed PRs). label Nov 1, 2026
@Jacksondr5
Jacksondr5 merged commit 3a89b64 into j5/main Nov 1, 2026
30 checks passed
@Jacksondr5
Jacksondr5 deleted the j5code/mobile-start-output branch November 1, 2026 02:47

This branch was successfully deployed

1 active deployment
Preview — 3be7762e Deployed Nov 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant