Repository navigation
fix(j5): the mobile rig leaves agent-device sessions to device_close - #973
Draft
Jacksondr5 wants to merge 1 commit into
Draft
Jacksondr5 wants to merge 1 commit into
Jacksondr5 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#872 made the rig's
stopandsetupclose agent-device sessions themselves, becausedevice_closeleft them open. That was an interim exception, approved until upstream's release on close (pingdotgg#21478) reached J5. The v0.1.7 advance (#971) brought it in:DeviceServicenow releases the agent-device session when a device is closed (releaseAgentSession→releaseAgentDeviceSessioninapps/server/src/device/AgentDeviceTarget.ts). Once the live install has that build, the rig's own cleanup, and its calls into the live install's agent-device, are no longer needed.What changed
In
scripts/j5/live-test-mobile.ts:closeAgentDeviceSessions,finishSessionCleanup,sessionsOnDevice, and thesessionCleanupPendingmarker that a fresh claim wrote intomobile.json.stopandsetupno longer call agent-device.agent-device closestep.serialRunningAvd, the lookup by AVD name thatstopalso uses to find the slot's emulator, and its test.A
mobile.jsonwritten by #872's build may still carrysessionCleanupPending. Nothing reads it now, so it's harmless.Testing
vp run check:changedpasses. The two removed test blocks covered only the removed functions.device_close, thenstop, then the next setup on that slot gets noDEVICE_IN_USE.Checklist
stopandsetupBuilt by Claude Opus 5.5 in Claude Code (J5 Code crew seat).
🤖 Generated with Claude Code